Disable Apache FallbackResource for faildumps #321
Conversation
andrewnicols
force-pushed
the
fallbackResourceDisabled
branch
from
998a15e to
817bd68
Compare
andrewnicols
force-pushed
the
fallbackResourceDisabled
branch
from
817bd68 to
76962d0
Compare
|
Pinging @marinaglancy, This should solve the issue. The docker image places the I've renamed the file to |
|
yes it works. |
|
Yes. That is the intended behaviour
Andrew Lyons
Principal Architect
Moodle HQ - moodle.com [image: Moodle - Empowering educators to improve our
world]
…On Wed, 2 Apr 2025 at 07:08, Marina Glancy ***@***.***> wrote:
it works in the way that the /_/faildumps/ listing is available, but does
not it remove the fallback to r.php completely?
—
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2K72IWFX26ZWVWQYUGHL2XML55AVCNFSM6AAAAAB2ED7CR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZQHA3TMNZZGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
[image: marinaglancy]*marinaglancy* left a comment
(moodlehq/moodle-docker#321)
<#321 (comment)>
it works in the way that the /_/faildumps/ listing is available, but does
not it remove the fallback to r.php completely?
—
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2K72IWFX26ZWVWQYUGHL2XML55AVCNFSM6AAAAAB2ED7CR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZQHA3TMNZZGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
Okay, replying now to you redited comment instead of the mail I recived So it's working in that the fallback is not applied to the |
|
le sigh: https://bz.apache.org/bugzilla/show_bug.cgi?id=52403#c7
Response:
Totally undocumented behaviour. There seem to be a couple of options to address this:
|
Set the handler to use for files whose extension ends in `.php`. This is a workaround for docker-library/php#1576 The `FallbackResource` is a default Handler action which is only used if a Handler has not already been applied. The docker/php image sets the handler unconditionally for any file whose name matches `.php`. This configuration block unsets the default handler, and instead only applies it if the file exists.
|
I've raised docker-library/php#1576 against the upstream Docker image. I've also raised a documentation issue against Apache: https://bz.apache.org/bugzilla/show_bug.cgi?id=69640 |
|
Sorry for editing the comment. I thought the fallback was not working but I was checking the "wrong" url. Good job finding the cause of it. |
|
If you're happy with the solution I've proposed here, please review + merge :0) |
|
I do not have formal permissions to review or merge in this repo. I confirm that both patches fix respective issues. |
|
@andrewnicols just one question. Sorry, I do not have a quick way to test it. Will there be the same problem with the fallback on moodle-php-apache when it is executed without moodle-docker (i.e. in GHA or gitlab ci)? |
|
Thanks both! |
|
Yes, but overrides need to be location specific. I’m hoping the upstream
images updates to use the IfMarch config too which will negate the second
issue.
Andrew Lyons
Principal Architect
Moodle HQ - moodle.com [image: Moodle - Empowering educators to improve our
world]
…On Wed, 2 Apr 2025 at 17:16, Marina Glancy ***@***.***> wrote:
@andrewnicols <https://github.com/andrewnicols> just one question. Sorry,
I do not have a quick way to test it. Will there be the same problem with
the fallback on moodle-php-apache when it is executed without moodle-docker
(i.e. in GHA or gitlab ci)?
—
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2K7ZP5RGRP4S2RTLC4J32XOTIJAVCNFSM6AAAAAB2ED7CR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZRHE2DINZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: marinaglancy]*marinaglancy* left a comment
(moodlehq/moodle-docker#321)
<#321 (comment)>
@andrewnicols <https://github.com/andrewnicols> just one question. Sorry,
I do not have a quick way to test it. Will there be the same problem with
the fallback on moodle-php-apache when it is executed without moodle-docker
(i.e. in GHA or gitlab ci)?
—
Reply to this email directly, view it on GitHub
<#321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2K7ZP5RGRP4S2RTLC4J32XOTIJAVCNFSM6AAAAAB2ED7CR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZRHE2DINZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Per docs in https://httpd.apache.org/docs/trunk/mod/mod_dir.html#fallbackresource the FallbackResource can be disabled using the {{disabled}} argument where it is set in a parent path.
Fixed #320