Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid holding issues just bumped from CLR to integration #332

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

mickhawkins
Copy link
Member

This should prevent issues being integration held if they were simply bumped from CLR back to integration during the freeze. It appears the task is run half hourly, so I set a 2 hour buffer just to cover any cases where it's delayed/doesn't run for some reason.

This is my first contribution to this repo, so please let me know if anything else is required (eg specific testing requirements).

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.50%. Comparing base (6851043) to head (5ff4ee1).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (6851043) and HEAD (5ff4ee1). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (6851043) HEAD (5ff4ee1)
verifications 1 0
upgrade_external_backup 1 0
verify_commit_messages 1 0
mustache_lint 1 0
prepare_npm_stuff 1 0
versions_check_set 1 0
compare_databases 1 0
grunt_process 1 0
remote_branch_checker 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #332       +/-   ##
==========================================
- Coverage   29.76%   8.50%   -21.27%     
==========================================
  Files          71      71               
  Lines        3222    3222               
==========================================
- Hits          959     274      -685     
- Misses       2263    2948      +685     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <ø> (ø)
checkstyle_manipulations 0.00% <ø> (ø)
compare_databases ?
continuous_manage_queues_validation 0.71% <ø> (ø)
define_excluded 1.11% <ø> (ø)
detect_conflicts 1.48% <ø> (ø)
diff_extract_changes 0.00% <ø> (ø)
grunt_process ?
illegal_whitespace 2.63% <ø> (ø)
list_valid_components 0.00% <ø> (ø)
mustache_lint ?
mustache_lint_plugins 1.30% <ø> (ø)
php_lint 1.21% <ø> (ø)
prepare_npm_stuff ?
remote_branch_checker ?
remote_branch_reporter 0.00% <ø> (ø)
setup 0.00% <ø> (ø)
thirdparty_check 1.45% <ø> (ø)
travis-branch-checker 0.00% <ø> (ø)
upgrade_external_backup ?
verifications ?
verify_commit_messages ?
versions_check_set ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mickhawkins. The patch looks good to me. I just made some minor amendments to your commit, capitalising the first letter of the statuses.

@junpataleta junpataleta merged commit 34a9d6b into moodlehq:main Mar 10, 2025
47 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants