Skip to content

MOBILE-4532 quiz: Update behat tests#3955

Open
marxjohnson wants to merge 1 commit into
moodlehq:mainfrom
marxjohnson:MOBILE-4532_main
Open

MOBILE-4532 quiz: Update behat tests#3955
marxjohnson wants to merge 1 commit into
moodlehq:mainfrom
marxjohnson:MOBILE-4532_main

Conversation

@marxjohnson

Copy link
Copy Markdown

MDL-68806 adds the new "Submitted" quiz attempt state, which means that once an attempt is submitted, grades will not be available until the ad-hoc tasks have run.

@NoelDeMartin NoelDeMartin self-requested a review March 5, 2024 12:45

@NoelDeMartin NoelDeMartin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some things to improve, but overall the changes are good to go.

However, the CI won't pass until MDL-68806 is integrated in core, so we can't merge this until then. Once we resolve the changes I suggested, I can approve this and then we'll be able to merge it as soon as the core issue is integrated.

Comment thread src/addons/mod/quiz/tests/behat/basic_usage.feature
Comment thread src/addons/mod/quiz/tests/behat/basic_usage.feature Outdated
Comment thread src/addons/mod/quiz/tests/behat/basic_usage.feature Outdated
Comment thread src/addons/mod/quiz/tests/behat/basic_usage.feature Outdated
MDL-68806 adds the new "Submitted" quiz attempt state, which means that
once an attempt is submitted, grades will not be available until the
ad-hoc tasks have run.
@marxjohnson

Copy link
Copy Markdown
Author

Thanks for the pointers @NoelDeMartin, and for providing that updated snapshot. I have pushed an updated branch with those changes.

@NoelDeMartin NoelDeMartin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marxjohnson, I think this could be merged now but as I mentioned we need to wait until MDL-68806 is integrated.

@crazyserver

Copy link
Copy Markdown
Member

Hi @marxjohnson, the issue has been integrated, could you please rebase your code?

@dpalou

dpalou commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

@crazyserver the original issue was split in 2, and the one that affects the app is MDL-82654 which hasn't been integrated yet.

@crazyserver

Copy link
Copy Markdown
Member

Oops, sorry my fault!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants