Skip to content

Conversation

aljosamakevic
Copy link
Contributor

@aljosamakevic aljosamakevic commented Sep 12, 2025

Description

On the page /builders/ethereum/dev-env/foundry, within the Using Forge Create section, I added --broadcast to the forge create terminal command because without it dry run mode is enabled and the tx doesn't actually get executed, thus the smart contract doesn't actually get deployed.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@aljosamakevic aljosamakevic self-assigned this Sep 12, 2025
@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 08:29
@aljosamakevic aljosamakevic requested a review from a team as a code owner September 12, 2025 08:29
@aljosamakevic aljosamakevic added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review C0 - Low Low priority task labels Sep 12, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a critical issue in the Foundry documentation where the forge create command was missing the --broadcast flag, causing deployment commands to run in dry-run mode instead of actually deploying contracts to the blockchain.

  • Added the --broadcast flag to all forge create commands across different networks
  • Ensures smart contracts are actually deployed rather than just simulated

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
llms-full.txt Added --broadcast flag to forge create commands in the generated documentation
llms-files/llms-ethereum-toolkit.txt Added --broadcast flag to forge create commands in the Ethereum toolkit documentation
llms-files/llms-dev-environments.txt Added --broadcast flag to forge create commands in the dev environments documentation
builders/ethereum/dev-env/foundry.md Added --broadcast flag to forge create commands in the main Foundry documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eshaben eshaben self-assigned this Sep 13, 2025
@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Sep 13, 2025
@eshaben eshaben merged commit 205231a into master Sep 15, 2025
4 of 5 checks passed
@eshaben eshaben deleted the forge-create-update branch September 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged C0 - Low Low priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants