-
Notifications
You must be signed in to change notification settings - Fork 98
runtime 3900 update #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime 3900 update #1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the documentation to include runtime 3900 information for the Moonbase Alpha network. This change adds a new runtime version entry to track the latest upgrade deployment.
- Updates the spec version to runtime-3900 in variables.yml
- Adds runtime 3900 entry to runtime upgrade tables across documentation files
- Changes quote style from single to double quotes throughout variables.yml for consistency
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
variables.yml | Updates spec_version to runtime-3900 and standardizes quote formatting |
llms-full.txt | Adds runtime 3900 row to runtime upgrades table |
llms-files/llms-xcm.txt | Adds runtime 3900 row to runtime upgrades table |
llms-files/llms-xcm-remote-execution.txt | Adds runtime 3900 row to runtime upgrades table |
llms-files/llms-xc-20.txt | Adds runtime 3900 row to runtime upgrades table |
llms-files/llms-tutorials.txt | Adds runtime 3900 row to runtime upgrades table |
llms-files/llms-tokens-and-accounts.txt | Adds runtime 3900 row to runtime upgrades table |
llms-files/llms-substrate-toolkit.txt | Adds runtime 3900 row to runtime upgrades table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I don't love the quote / spacing changes but I'll let the @eshaben's regulators team decide on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any spacing issues, but we can rollback the double quotes to single quotes. I don't have a strong opinion on this
Noted. I've changed the double quotes back to single quotes and edited my prettier config so this doesn't happen again |
Style Guide Violations Summary
|
Verification ReviewThis review focuses on style guide claims, justifications, and confidence scores in the provided documents.
|
@aljosamakevic I just merged another PR that bumped the client version to v0.47.0, so now there are some merge conflicts here. Can you please address merge conflicts? And please also make sure llms check has been run. Thanks!! |
@eshaben done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Updated variables.yml with the runtime 3900 and the runtime-upgrades.md with a new row dedicated to runtime 3900
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.