-
Notifications
You must be signed in to change notification settings - Fork 98
Revise Call Permit Precompile #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the Call Permit Precompile documentation to improve accuracy and consistency across multiple files. The changes focus on correcting JavaScript code for UNIX timestamp generation and enhancing the presentation of signature output examples.
Key changes:
- Fixed JavaScript timestamp generation from
Date.now()
toMath.floor(Date.now() / 1000)
to return UNIX seconds instead of milliseconds - Replaced static image references with interactive terminal-style HTML snippets for signature output visualization
- Updated image references to ensure correct visual documentation alignment
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
llms-full.txt |
Updated timestamp generation code and replaced signature output image with terminal snippet |
llms-files/llms-precompiles.txt |
Applied same timestamp and signature output improvements |
llms-files/llms-ethereum-toolkit.txt |
Updated timestamp generation and signature visualization |
builders/ethereum/precompiles/ux/call-permit.md |
Fixed timestamp code and replaced image with snippet reference |
.snippets/code/builders/ethereum/precompiles/ux/call-permit/signature-output.md |
New file containing terminal-style signature output HTML |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.snippets/code/builders/ethereum/precompiles/ux/call-permit/signature-output.md
Outdated
Show resolved
Hide resolved
…gnature-output.md Co-authored-by: Copilot <[email protected]>
Style Guide Violations Summary
|
Verification ReviewThis review focuses on style guide claims, justifications, and confidence scores in the provided documents.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This pull request updates the documentation and code snippets for the Ethereum Call Permit Precompile to improve clarity and accuracy, especially around handling UNIX timestamps for the
deadline
parameter and visualizing signature outputs. The changes also enhance consistency across multiple files and replace static images with interactive terminal-style outputs.Documentation improvements:
deadline
parameter to useconsole.log(Math.floor(Date.now() / 1000))
for correct UNIX seconds in JavaScript, replacing previous usage ofDate.now()
which returned milliseconds. This change is applied across all relevant documentation and reference files. [1] [2] [3] [4] [5] [6] [7] [8]Signature output visualization:
<div id="termynal">
) that displays the output ofnode getSignature.js
, including all signature components (r
,s
,v
, etc.), in both documentation and reference files. [1] [2] [3] [4] [5]Image consistency and accuracy:
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.