Skip to content

Conversation

themacexpert
Copy link
Contributor

Description

This pull request updates the documentation for Moonbeam node operators and collators to include the new --pool-type flag in all relevant start-up command examples and adds a detailed explanation of its usage and options. This helps users configure transaction pool behavior for improved handling of forks and reorgs, and ensures the documentation matches current Moonbeam builds.

Documentation updates for transaction pool configuration:

Expanded flag reference and guidance:

  • Added a new section describing the --pool-type flag, its available options (fork-aware and single-state), and guidance on when to use each. This clarifies the benefits of the fork-aware pool and notes its status as the default on recent Moonbeam builds. [1] [2]

Checklist

  • Added a label 🏷️ to this PR
  • Ran my changes through Grammarly
  • Added a disclaimer if required
  • If pages were moved, opened a corresponding PR in moonbeam-mkdocs to update redirects

Translations

Does this PR update a page that also exists on the Chinese docs site? See mapping to confirm.

  • Yes
  • No

If Yes, complete the following:

  • Opened a PR on the Chinese docs repo for the corresponding page
  • Updated images, snippets, or variables if they were moved, renamed, or deleted

Link to the corresponding CN docs PR: <INSERT_LINK>

@themacexpert themacexpert requested a review from a team as a code owner October 3, 2025 21:10
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 21:10
@themacexpert themacexpert added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Oct 3, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the --pool-type=fork-aware flag to Moonbeam node operator documentation to reflect current build recommendations and improve transaction pool behavior during forks and reorgs.

  • Added --pool-type=fork-aware flag to all node and collator startup command examples
  • Added comprehensive documentation explaining the --pool-type flag options and usage
  • Updated both main documentation files and LLM training files for consistency

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
node-operators/networks/run-a-node/flags.md Added detailed documentation for the --pool-type flag explaining fork-aware vs single-state options
node-operators/networks/run-a-node/docker.md Added --pool-type=fork-aware flag to all Docker startup command examples for nodes and collators
llms-full.txt Updated LLM training data with the same flag additions and documentation
llms-files/llms-node-operators-and-collators.txt Updated specialized LLM training file with consistent flag additions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Oct 3, 2025

Style Guide Violations Summary

node-operators/networks/run-a-node/docker.md (Line 269)

  • Issue:
    Placeholder comment '# This is a comment' appears in executable command block, which would break the command if copied. Comments should be removed from executable command examples or properly documented outside code blocks.

  • Correction:

--trie-cache-size 1073741824 \

node-operators/networks/run-a-node/flags.md (Line 50)

  • Issue:
    Uses dash instead of colon after bold term; description should start with capital letter

  • Correction:

- **`--pool-type`**: Selects the transaction pool implementation. The available options are:

node-operators/networks/run-a-node/flags.md (Line 51)

  • Issue:
    Uses dash instead of colon after bold term; description should start with capital letter and end with period

  • Correction:

- **`fork-aware`**: Tracks pending transactions across competing forks ("views"), which reduces dropped/re-validated transactions and nonce/order glitches during brief reorgs. This is the default on current Moonbeam builds (Polkadot SDK change; default from ~RT3600+) and is recommended on collators and RPC nodes.

node-operators/networks/run-a-node/flags.md (Line 52)

  • Issue:
    Uses dash instead of colon after bold term; description should start with capital letter and end with period

  • Correction:

- **`single-state`**: Uses the legacy single-view pool. On older binaries, explicitly set `--pool-type=fork-aware` to opt in to the improved implementation.

Copy link

github-actions bot commented Oct 3, 2025

Verification Review

This review focuses on style guide claims, justifications, and confidence scores in the provided documents.


node-operators/networks/run-a-node/flags.md (Line 51)

  • Claim:
    tracks pending transactions across competing forks ("views"), which reduces dropped/re-validated transactions and nonce/order glitches during brief reorgs

  • Context:

  • fork-aware - tracks pending transactions across competing forks ("views"), which reduces dropped/re-validated transactions and nonce/order glitches during brief reorgs. This is the default on current Moonbeam builds (Polkadot SDK change; default from ~RT3600+) and is recommended on collators and RPC nodes
  • Justification:

Cause-and-effect claim about transaction pool behavior requires verification against actual implementation to confirm reduction of glitches during reorgs

  • Requires Verification: Yes
  • Confidence Score: 0.85

node-operators/networks/run-a-node/flags.md (Line 51)

  • Claim:
    This is the default on current Moonbeam builds (Polkadot SDK change; default from ~RT3600+)

  • Context:

- **`fork-aware`** - tracks pending transactions across competing forks ("views"), which reduces dropped/re-validated transactions and nonce/order glitches during brief reorgs. This is the default on current Moonbeam builds (Polkadot SDK change; default from ~RT3600+) and is recommended on collators and RPC nodes
  • Justification:

Version-qualified claim about default behavior may become inaccurate with newer releases and requires version-specific documentation verification

  • Requires Verification: Yes
  • Confidence Score: 0.92

@themacexpert themacexpert changed the title Add Fork Aware Pool Flag Add Fork Aware Pool Flag + Flags Overhaul Oct 6, 2025
@themacexpert themacexpert added A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) and removed A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Oct 6, 2025
@themacexpert
Copy link
Contributor Author

Refreshed all flags and updated according to style guide

aljosamakevic
aljosamakevic previously approved these changes Oct 7, 2025
dawnkelly09
dawnkelly09 previously approved these changes Oct 13, 2025
Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a couple of highlight lines. Looks nice!

Copy link
Contributor

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@Telucero Telucero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@themacexpert themacexpert added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Oct 14, 2025
@eshaben eshaben merged commit 361deef into master Oct 14, 2025
3 checks passed
@eshaben eshaben deleted the themacexpert/nodeins branch October 14, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) B1 - Ready to Merge Pull request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants