-
Notifications
You must be signed in to change notification settings - Fork 98
Add Fork Aware Pool Flag + Flags Overhaul #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the --pool-type=fork-aware
flag to Moonbeam node operator documentation to reflect current build recommendations and improve transaction pool behavior during forks and reorgs.
- Added
--pool-type=fork-aware
flag to all node and collator startup command examples - Added comprehensive documentation explaining the
--pool-type
flag options and usage - Updated both main documentation files and LLM training files for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
node-operators/networks/run-a-node/flags.md | Added detailed documentation for the --pool-type flag explaining fork-aware vs single-state options |
node-operators/networks/run-a-node/docker.md | Added --pool-type=fork-aware flag to all Docker startup command examples for nodes and collators |
llms-full.txt | Updated LLM training data with the same flag additions and documentation |
llms-files/llms-node-operators-and-collators.txt | Updated specialized LLM training file with consistent flag additions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Style Guide Violations Summary
|
Verification ReviewThis review focuses on style guide claims, justifications, and confidence scores in the provided documents.
|
Refreshed all flags and updated according to style guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a couple of highlight lines. Looks nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This pull request updates the documentation for Moonbeam node operators and collators to include the new
--pool-type
flag in all relevant start-up command examples and adds a detailed explanation of its usage and options. This helps users configure transaction pool behavior for improved handling of forks and reorgs, and ensures the documentation matches current Moonbeam builds.Documentation updates for transaction pool configuration:
--pool-type=fork-aware
flag to all node and collator start-up command examples in bothllms-files/llms-node-operators-and-collators.txt
andllms-full.txt
, reflecting the recommended configuration for current Moonbeam builds. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32]Expanded flag reference and guidance:
--pool-type
flag, its available options (fork-aware
andsingle-state
), and guidance on when to use each. This clarifies the benefits of the fork-aware pool and notes its status as the default on recent Moonbeam builds. [1] [2]Checklist
moonbeam-mkdocs
to update redirectsTranslations
Does this PR update a page that also exists on the Chinese docs site? See mapping to confirm.
If Yes, complete the following:
Link to the corresponding CN docs PR: <INSERT_LINK>