-
Notifications
You must be signed in to change notification settings - Fork 98
Moonbeam RT Upgrade 3900 #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Moonbeam RT Upgrade 3900 #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates documentation and configuration to reflect the Moonbeam runtime upgrade 3900 release. The changes ensure all references to runtime versions and block numbers are current and accurate.
Key changes:
- Updated Moonbeam spec_version from runtime-3800 to runtime-3900 in configuration
- Added Moonbeam block number for runtime 3900 upgrade in documentation table
- Corrected source code line reference for XCM weight conversion constant
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
variables.yml | Updates spec_version to runtime-3900 for Moonbeam network configuration |
builders/build/runtime-upgrades.md | Adds Moonbeam block number (12960124) for runtime 3900 upgrade |
builders/interoperability/xcm/core-concepts/weights-fees.md | Updates source code line reference from L163 to L165 for XCM weight constant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| [3702](https://forum.moonbeam.network/t/proposals-mr81-mb118-authorize-upgrade-to-rt3702-on-moonriver-and-moonbeam-via-whitelist/2173){target=\_blank} | [11499659](https://moonbeam.subscan.io/block/11499659){target=\_blank} | [12156948](https://moonriver.subscan.io/block/12156948){target=\_blank} | [12683255](https://moonbase.subscan.io/block/12683255){target=\_blank} | | ||
| [3800](https://forum.moonbeam.network/t/runtime-rt3800-schedule/2188){target=\_blank} | [12120762](https://moonbeam.subscan.io/block/12120762){target=\_blank} | [12540836](https://moonriver.subscan.io/block/12540836){target=\_blank} | [12853655](https://moonbase.subscan.io/block/12853655){target=\_blank} | | ||
| [3900](https://forum.moonbeam.network/t/runtime-rt3900-schedule/2262){target=\_blank} | - | [13423617](https://moonriver.subscan.io/block/13423617){target=\_blank} | [13744972](https://moonbase.subscan.io/block/13744972){target=\_blank} | | ||
| [3900](https://forum.moonbeam.network/t/runtime-rt3900-schedule/2262){target=\_blank} | [12960124](https://moonbeam.subscan.io/block/12960124){target=\_blank} | [13423617](https://moonriver.subscan.io/block/13423617){target=\_blank} | [13744972](https://moonbase.subscan.io/block/13744972){target=\_blank} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this block is in 3800
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been using this extrinsic: system (CodeUpdated) as the old runtimeUpgradeStarted is decommed (https://moonbeam.subscan.io/event?module=migrations&event_id=RuntimeUpgradeStarted)
It takes a few blocks before the runtime is considered complete, so it the new runtime number will show in the spec version 2 blocks later in that particular example. Open to ideas if you want to reconsider which block number we show.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there's no way to get the exact block? I went 2 blocks later and it still wasn't 3900. Just kiddinggg, I was originally on the wrong block haha. Ok, so it's always going to be 2 blocks later? So far we've been consistent in this table showing the exact block, so I'd like to try to keep doing that if it's feasible
Style Guide Violations Summary
|
Verification ReviewThis review focuses on style guide claims, justifications, and confidence scores in the provided documents.
|
Description
This pull request updates documentation and configuration files to reflect the release of the Moonbeam runtime upgrade 3900. The changes ensure that references to the latest runtime version and corresponding block numbers are accurate across the codebase.
Runtime upgrade references:
builders/build/runtime-upgrades.md
to include the block number for the 3900 upgrade on Moonbeam, ensuring consistency with Moonriver and Moonbase Alpha.spec_version
for Moonbeam fromruntime-3800
toruntime-3900
invariables.yml
, aligning configuration with the latest release.Documentation accuracy:
builders/interoperability/xcm/core-concepts/weights-fees.md
fromlib.rs#L163
tolib.rs#L165
, reflecting changes in the source code location for the relevant constant.Checklist
moonbeam-mkdocs
to update redirectsTranslations
Does this PR update a page that also exists on the Chinese docs site? See mapping to confirm.
If Yes, complete the following:
Link to the corresponding CN docs PR: <INSERT_LINK>