Skip to content

Conversation

themacexpert
Copy link
Contributor

Description

This pull request updates documentation and configuration files to reflect the release of the Moonbeam runtime upgrade 3900. The changes ensure that references to the latest runtime version and corresponding block numbers are accurate across the codebase.

Runtime upgrade references:

  • Updated the runtime upgrade table in builders/build/runtime-upgrades.md to include the block number for the 3900 upgrade on Moonbeam, ensuring consistency with Moonriver and Moonbase Alpha.
  • Changed the spec_version for Moonbeam from runtime-3800 to runtime-3900 in variables.yml, aligning configuration with the latest release.

Documentation accuracy:

  • Updated the line reference in the Moonbeam XCM instruction weight-to-balance conversion table in builders/interoperability/xcm/core-concepts/weights-fees.md from lib.rs#L163 to lib.rs#L165, reflecting changes in the source code location for the relevant constant.

Checklist

  • Added a label 🏷️ to this PR
  • Ran my changes through Grammarly
  • Added a disclaimer if required
  • If pages were moved, opened a corresponding PR in moonbeam-mkdocs to update redirects

Translations

Does this PR update a page that also exists on the Chinese docs site? See mapping to confirm.

  • Yes
  • No

If Yes, complete the following:

  • Opened a PR on the Chinese docs repo for the corresponding page
  • Updated images, snippets, or variables if they were moved, renamed, or deleted

Link to the corresponding CN docs PR: <INSERT_LINK>

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 16:03
@themacexpert themacexpert added the A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) label Oct 14, 2025
@themacexpert themacexpert requested a review from a team as a code owner October 14, 2025 16:03
@themacexpert themacexpert added the B0 - Needs Review Pull request is ready for review label Oct 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation and configuration to reflect the Moonbeam runtime upgrade 3900 release. The changes ensure all references to runtime versions and block numbers are current and accurate.

Key changes:

  • Updated Moonbeam spec_version from runtime-3800 to runtime-3900 in configuration
  • Added Moonbeam block number for runtime 3900 upgrade in documentation table
  • Corrected source code line reference for XCM weight conversion constant

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
variables.yml Updates spec_version to runtime-3900 for Moonbeam network configuration
builders/build/runtime-upgrades.md Adds Moonbeam block number (12960124) for runtime 3900 upgrade
builders/interoperability/xcm/core-concepts/weights-fees.md Updates source code line reference from L163 to L165 for XCM weight constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

| [3702](https://forum.moonbeam.network/t/proposals-mr81-mb118-authorize-upgrade-to-rt3702-on-moonriver-and-moonbeam-via-whitelist/2173){target=\_blank} | [11499659](https://moonbeam.subscan.io/block/11499659){target=\_blank} | [12156948](https://moonriver.subscan.io/block/12156948){target=\_blank} | [12683255](https://moonbase.subscan.io/block/12683255){target=\_blank} |
| [3800](https://forum.moonbeam.network/t/runtime-rt3800-schedule/2188){target=\_blank} | [12120762](https://moonbeam.subscan.io/block/12120762){target=\_blank} | [12540836](https://moonriver.subscan.io/block/12540836){target=\_blank} | [12853655](https://moonbase.subscan.io/block/12853655){target=\_blank} |
| [3900](https://forum.moonbeam.network/t/runtime-rt3900-schedule/2262){target=\_blank} | - | [13423617](https://moonriver.subscan.io/block/13423617){target=\_blank} | [13744972](https://moonbase.subscan.io/block/13744972){target=\_blank} |
| [3900](https://forum.moonbeam.network/t/runtime-rt3900-schedule/2262){target=\_blank} | [12960124](https://moonbeam.subscan.io/block/12960124){target=\_blank} | [13423617](https://moonriver.subscan.io/block/13423617){target=\_blank} | [13744972](https://moonbase.subscan.io/block/13744972){target=\_blank} |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this block is in 3800

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using this extrinsic: system (CodeUpdated) as the old runtimeUpgradeStarted is decommed (https://moonbeam.subscan.io/event?module=migrations&event_id=RuntimeUpgradeStarted)

It takes a few blocks before the runtime is considered complete, so it the new runtime number will show in the spec version 2 blocks later in that particular example. Open to ideas if you want to reconsider which block number we show.

Copy link
Contributor

@eshaben eshaben Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there's no way to get the exact block? I went 2 blocks later and it still wasn't 3900. Just kiddinggg, I was originally on the wrong block haha. Ok, so it's always going to be 2 blocks later? So far we've been consistent in this table showing the exact block, so I'd like to try to keep doing that if it's feasible

Copy link

Style Guide Violations Summary

builders/build/runtime-upgrades.md (Line 100)

  • Issue:
    Inconsistent table cell padding; first column has excessive spaces compared to other columns violating table formatting standards

  • Correction:

| [3900](https://forum.moonbeam.network/t/runtime-rt3900-schedule/2262){target=_blank} | [12960124](https://moonbeam.subscan.io/block/12960124){target=_blank} | [13423617](https://moonriver.subscan.io/block/13423617){target=_blank} | [13744972](https://moonbase.subscan.io/block/13744972){target=_blank} |

builders/interoperability/xcm/core-concepts/weights-fees.md (Line 153)

  • Issue:
    Important numeric values representing code constants should be bolded as they are 'can't-miss, important things' per style guide

  • Correction:

| **[{{ networks.moonbeam.xcm.instructions.wei_per_weight.display }}](https://github.com/moonbeam-foundation/moonbeam/blob/{{networks.moonbeam.spec_version}}/runtime/moonbeam/src/lib.rs#L165){target=_blank}** | **[{{ networks.moonriver.xcm.instructions.wei_per_weight.display }}](https://github.com/moonbeam-foundation/moonbeam/blob/{{networks.moonriver.spec_version}}/runtime/moonriver/src/lib.rs#L173){target=_blank}** | **[{{ networks.moonbase.xcm.instructions.wei_per_weight.display }}](https://github.com/moonbeam-foundation/moonbeam/blob/{{networks.moonbase.spec_version}}/runtime/moonbase/src/lib.rs#L169){target=_blank}** |

Copy link

Verification Review

This review focuses on style guide claims, justifications, and confidence scores in the provided documents.


builders/build/runtime-upgrades.md (Line 96)

  • Claim:
    12960124{target=_blank}

  • Context:

| 3900{target=_blank} | 12960124{target=_blank} | 13423617{target=_blank} | 13744972{target=_blank} |

  • Justification:

The block number for a runtime upgrade is a specific factual data point that must be verified against the blockchain explorer to ensure accuracy and avoid documentation errors.

  • Requires Verification: Yes
  • Confidence Score: 1

@themacexpert themacexpert requested a review from eshaben October 16, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) B0 - Needs Review Pull request is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants