Skip to content

updates gas_block for moonbase from 15mln to 30mln for RT3100 #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2024
Merged

updates gas_block for moonbase from 15mln to 30mln for RT3100 #985

merged 3 commits into from
Sep 3, 2024

Conversation

dawnkelly09
Copy link
Contributor

Description

Updates variables.yml gas_block variable for moonbeam from 15mln to 30mln for runtime 3100 update

Checklist

  • [x ] I have added a label to this PR 🏷️

@dawnkelly09 dawnkelly09 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Aug 28, 2024
@dawnkelly09 dawnkelly09 requested a review from eshaben August 28, 2024 16:54
@dawnkelly09 dawnkelly09 marked this pull request as ready for review September 3, 2024 12:58
albertov19
albertov19 previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eshaben
eshaben reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional variables need to be updated. So just waiting til those changes come in to merge

@dawnkelly09 dawnkelly09 requested a review from eshaben September 3, 2024 16:53
eshaben
eshaben approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit f4f76e4 into master Sep 3, 2024
@eshaben eshaben deleted the dawn/block-gas-limit branch September 3, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eshaben eshaben eshaben approved these changes

@albertov19 albertov19 albertov19 left review comments

Assignees

No one assigned

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dawnkelly09 @eshaben @albertov19