Skip to content

Conversation

@RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Oct 8, 2025

What does it do?

This feature is still to be implemented and supported in choptsticks, once ready, this test should pass.

Tests support for chopsticks fake signatures

@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rq/support-fake-signature-in-chopsticks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 1992 KB (no changes) ✅

Moonbeam runtime: 2104 KB (no changes) ✅

Moonriver runtime: 2104 KB (no changes) ✅

Compared to latest release (runtime-3900)

Moonbase runtime: 1992 KB (-368 KB compared to latest release) ✅

Moonbeam runtime: 2104 KB (-376 KB compared to latest release) ✅

Moonriver runtime: 2104 KB (-376 KB compared to latest release) ✅

@RomarQ RomarQ self-assigned this Oct 8, 2025
@RomarQ RomarQ added the B0-silent Changes should not be mentioned in any release notes label Oct 8, 2025
@RomarQ RomarQ changed the title Support Chopsticks fake signature Test: support for Chopsticks fake signature Oct 8, 2025
@timbrinded
Copy link
Contributor

timbrinded commented Oct 10, 2025

why not just use moonwall's built in chopsticks helpers?:
https://github.com/Moonsong-Labs/moonwall/blob/d25dd555bb1fb2802f394cba70714d66903beaf6/test/suites/chopsticks/test-chopsticks-basic.ts#L87

(fake signature helpers are pure functions so should be able to work with chopsticks instance managed by moonwall)

@RomarQ
Copy link
Contributor Author

RomarQ commented Oct 10, 2025

why not just use moonwall's built in chopsticks helpers?: https://github.com/Moonsong-Labs/moonwall/blob/d25dd555bb1fb2802f394cba70714d66903beaf6/test/suites/chopsticks/test-chopsticks-basic.ts#L87

(fake signature helpers are pure functions so should be able to work with chopsticks instance managed by moonwall)

This is purely experimental for now, moonwall is usually enough for most things, but for example when you want to other capabilities of chopsticks, like https://github.com/AcalaNetwork/chopsticks?tab=readme-ov-file#dry-run, it does not support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants