-
Notifications
You must be signed in to change notification settings - Fork 380
Add Asset HUB support to XCM transactor #3543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WASM runtime size check:Compared to target branchMoonbase runtime: 1996 KB (+8 KB) Moonbeam runtime: 2116 KB (+8 KB) Moonriver runtime: 2116 KB (+8 KB) Compared to latest release (runtime-4001)Moonbase runtime: 1996 KB (+224 KB compared to latest release) Moonbeam runtime: 2116 KB (+252 KB compared to latest release) Moonriver runtime: 2116 KB (+252 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master manuel/upgrade-xcm-transactor +/- ##
=================================================================
+ Coverage 74.71% 74.73% +0.02%
+ Files 397 405 +8
+ Lines 96483 97981 +1498
=================================================================
+ Hits 72085 73219 +1134
+ Misses 24398 24762 +364
|
runtime/moonbase/src/xcm_config.rs
Outdated
| pub enum Transactors { | ||
| /// Relay Chain (Westend for Moonbase) | ||
| Relay, | ||
| /// AssetHub system parachain (para 1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// AssetHub system parachain (para 1000) | |
| /// AssetHub system parachain |
runtime/moonbase/src/xcm_config.rs
Outdated
| Transactors::Relay => Location::parent(), | ||
| Transactors::AssetHub => Location { | ||
| parents: 1, | ||
| interior: [Parachain(1000)].into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Moonbase Alpha, the AssetHub ParachainID is 1001
| interior: [Parachain(1000)].into(), | |
| interior: [Parachain(1001)].into(), |
What does it do?
This PR extends the XCM Transactor pallet to support AssetHub as a transaction destination, enabling Moonbeam users to execute staking operations and other remote calls on the AssetHub system parachain (Polkadot/Kusama/Westend).
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?