Skip to content

Conversation

@RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 24, 2025

What does it do?

This PR removes multi-block migrations applied in runtime 4000, which are no longer needed

@RomarQ RomarQ self-assigned this Nov 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rq/remove-old-migrations2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomarQ RomarQ requested a review from manuelmauro November 24, 2025 09:59
@RomarQ RomarQ added the B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes label Nov 24, 2025
@RomarQ RomarQ added not-breaking Does not need to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 24, 2025
@RomarQ RomarQ requested a review from librelois November 24, 2025 10:37
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 1980 KB (-8 KB) ✅

Moonbeam runtime: 2104 KB (-4 KB) ✅

Moonriver runtime: 2104 KB (-4 KB) ✅

Compared to latest release (runtime-4001)

Moonbase runtime: 1980 KB (+208 KB compared to latest release) ⚠️

Moonbeam runtime: 2104 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2104 KB (+240 KB compared to latest release) ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Coverage Report

@@                     Coverage Diff                      @@
##           master   rq/remove-old-migrations2     +/-   ##
============================================================
  Coverage   74.62%                      74.62%   0.00%     
  Files         394                         394             
  Lines       95725                       95725             
============================================================
- Hits        71429                       71426      -3     
+ Misses      24296                       24299      +3     
Files Changed Coverage
/runtime/common/src/migrations.rs 0.00% (-7.89%) 🔽

Coverage generated Mon Nov 24 12:02:01 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants