-
Notifications
You must be signed in to change notification settings - Fork 380
Remove parachain staking lazy migration added in #3306 #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Moonbase Weight Difference Report
Moonriver Weight Difference Report
Moonbeam Weight Difference Report
|
WASM runtime size check:Compared to target branchMoonbase runtime: 1992 KB (+4 KB) Moonbeam runtime: 2100 KB (-8 KB) ✅ Moonriver runtime: 2104 KB (-4 KB) ✅ Compared to latest release (runtime-4001)Moonbase runtime: 1992 KB (+220 KB compared to latest release) Moonbeam runtime: 2100 KB (+236 KB compared to latest release) Moonriver runtime: 2104 KB (+240 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/remove-parachain-staking-lazy-migration +/- ##
==============================================================================
- Coverage 74.62% 74.50% -0.12%
- Files 394 392 -2
- Lines 95725 95054 -671
==============================================================================
- Hits 71429 70813 -616
- Misses 24296 24241 -55
|
What does it do?
This pull request is a follow-up of #3306, which migrated the parachain staking pallet from the deprecated
Currencytrait to the modernFungibletrait, replacing the old lock-based system with a freeze-based mechanism.The lazy-migration was performed in runtime 4000 and is no-longer needed.