Skip to content

Conversation

@RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 24, 2025

What does it do?

This pull request is a follow-up of #3306, which migrated the parachain staking pallet from the deprecated Currency trait to the modern Fungible trait, replacing the old lock-based system with a freeze-based mechanism.

The lazy-migration was performed in runtime 4000 and is no-longer needed.

@RomarQ RomarQ self-assigned this Nov 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rq/remove-parachain-staking-lazy-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Moonbase Weight Difference Report

File Extrinsic Old New Change Percent

Moonriver Weight Difference Report

File Extrinsic Old New Change Percent

Moonbeam Weight Difference Report

File Extrinsic Old New Change Percent

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes labels Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 1992 KB (+4 KB) ⚠️

Moonbeam runtime: 2100 KB (-8 KB) ✅

Moonriver runtime: 2104 KB (-4 KB) ✅

Compared to latest release (runtime-4001)

Moonbase runtime: 1992 KB (+220 KB compared to latest release) ⚠️

Moonbeam runtime: 2100 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2104 KB (+240 KB compared to latest release) ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Coverage Report

@@                              Coverage Diff                               @@
##           master   rq/remove-parachain-staking-lazy-migration      +/-   ##
==============================================================================
- Coverage   74.62%                                       74.50%   -0.12%     
- Files         394                                          392       -2     
- Lines       95725                                        95054     -671     
==============================================================================
- Hits        71429                                        70813     -616     
- Misses      24296                                        24241      -55     
Files Changed Coverage
/pallets/parachain-staking/src/lib.rs 93.16% (-0.01%) 🔽
/pallets/parachain-staking/src/weights.rs 44.21% (+1.30%) 🔼
/runtime/common/src/migrations.rs 7.50% (-0.39%) 🔽
/runtime/moonbase/src/weights/pallet_parachain_staking.rs 24.81% (+0.84%) 🔼
/runtime/moonbeam/src/weights/pallet_parachain_staking.rs 24.81% (+0.84%) 🔼
/runtime/moonriver/src/weights/pallet_parachain_staking.rs 24.81% (+0.84%) 🔼

Coverage generated Mon Nov 24 16:52:33 UTC 2025

@RomarQ RomarQ added the D3-trivial PR contains trivial changes in a runtime directory that do not require an audit label Nov 24, 2025
@RomarQ RomarQ marked this pull request as ready for review November 24, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants