Skip to content

Conversation

@manuelmauro
Copy link
Contributor

What does it do?

Adds new tests for eth_subscribe.

@manuelmauro manuelmauro self-assigned this Dec 16, 2025
@manuelmauro manuelmauro added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Dec 16, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch manuel/test-reorgs-in-eth-subscribe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2124 KB (no changes) ✅

Moonbeam runtime: 2240 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-4100)

Moonbase runtime: 2124 KB (+188 KB compared to latest release) ⚠️

Moonbeam runtime: 2240 KB (+208 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+208 KB compared to latest release) ⚠️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Coverage Report

@@                           Coverage Diff                           @@
##           master   manuel/test-reorgs-in-eth-subscribe      +/-   ##
=======================================================================
+ Coverage   76.70%                                76.71%   +0.01%     
  Files         389                                   389              
- Lines       76595                                 76585      -10     
=======================================================================
  Hits        58745                                 58745              
- Misses      17850                                 17840      -10     
Files Changed Coverage
/node/service/src/lib.rs 49.01% (+0.48%) 🔼

Coverage generated Thu Dec 18 11:56:05 UTC 2025

manuelmauro and others added 5 commits December 16, 2025 13:21
* test: ✅ add smoke tests for eth_subscribe

* test: ✅ update test expectations

* chore: 📌 update pin

* revert: 🔥 remove redundant test

* refactor: ♻️ merge newHeads smoke tests into a single one

---------

Co-authored-by: Rodrigo Quelhas <[email protected]>
@manuelmauro
Copy link
Contributor Author

Closing in favor of #3597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants