-
Notifications
You must be signed in to change notification settings - Fork 384
Add new tests for eth_subscribe
#3594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
WASM runtime size check:Compared to target branchMoonbase runtime: 2124 KB (no changes) ✅ Moonbeam runtime: 2240 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-4100)Moonbase runtime: 2124 KB (+188 KB compared to latest release) Moonbeam runtime: 2240 KB (+208 KB compared to latest release) Moonriver runtime: 2240 KB (+208 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master manuel/test-reorgs-in-eth-subscribe +/- ##
=======================================================================
+ Coverage 76.70% 76.71% +0.01%
Files 389 389
- Lines 76595 76585 -10
=======================================================================
Hits 58745 58745
- Misses 17850 17840 -10
|
* test: ✅ add smoke tests for eth_subscribe * test: ✅ update test expectations * chore: 📌 update pin * revert: 🔥 remove redundant test * refactor: ♻️ merge newHeads smoke tests into a single one --------- Co-authored-by: Rodrigo Quelhas <[email protected]>
This reverts commit 631e659.
|
Closing in favor of #3597 |
What does it do?
Adds new tests for
eth_subscribe.