Skip to content

feat: include the new DNS multiaddr filtering policy for node operators.#3790

Open
librelois wants to merge 1 commit into
masterfrom
elois/dns-policy
Open

feat: include the new DNS multiaddr filtering policy for node operators.#3790
librelois wants to merge 1 commit into
masterfrom
elois/dns-policy

Conversation

@librelois

@librelois librelois commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Goal

Update the polkadot-sdk pin from e4d0430705cf7e0c31ef3ad6a8de8e671212a679 to 09e2fee3c53b217db27ea1197ef045048a95ca7b to include the new DNS multiaddr filtering policy for node operators.

What reviewers need to know

This is a Cargo.lock-only dependency pin update. The important upstream change is 09e2fee3c53b217db27ea1197ef045048a95ca7b, which adds opt-in DNS multiaddr filtering to sc-cli/sc-network:

  • --deny-untrusted-dns-multiaddrs denies DNS multiaddresses learned from untrusted discovery sources.
  • --deny-dns-suffixes <suffixes> denies DNS multiaddresses matching configured suffixes.
  • Default behavior is unchanged: DNS multiaddresses remain allowed unless operators enable the new policy.
  • The policy is wired through both libp2p and litep2p discovery paths, including known addresses, self-reported addresses, DHT/provider results, and external address handling.

The pin bump also includes two smaller upstream commits:

  • improved weight reclaim logging, adding call metadata and lowering the relevant log level to warn;
  • an xcm-emulator extension that allows non-Aura parachains to override block/digest production, which supports Moonbeam/Nimbus-based integration testing.

No runtime storage, extrinsic, RPC, or default node behavior changes are expected from this PR. The operator-facing DNS filtering behavior is opt-in through the new CLI flags.


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

Add DNS multiaddr filtering CLI policy
@librelois librelois added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f334be35-943f-4b67-b54a-21995ba55ce3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch elois/dns-policy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant