Skip to content

fix: SafeCallFilter XCM Transact vulnerability (Immunefi #81386) #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ouwibo wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −12
Open

fix: SafeCallFilter XCM Transact vulnerability (Immunefi #81386) #3798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions runtime/moonbase/src/xcm_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,14 @@ moonbeam_runtime_common::impl_evm_runner_precompile_or_eth_xcm!();

pub struct SafeCallFilter;
impl frame_support::traits::Contains<RuntimeCall> for SafeCallFilter {
fn contains(_call: &RuntimeCall) -> bool {
// TODO review
// This needs to be addressed at EVM level
true
fn contains(call: &RuntimeCall) -> bool {
match call {
RuntimeCall::Balances(_) => true,
RuntimeCall::Ethereum(_) => true,
RuntimeCall::EVM(_) => true,
RuntimeCall::Utility(_) => true,
_ => false,
}
}
}

Expand Down
12 changes: 8 additions & 4 deletions runtime/moonbeam/src/xcm_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,14 @@ parameter_types! {

pub struct SafeCallFilter;
impl frame_support::traits::Contains<RuntimeCall> for SafeCallFilter {
fn contains(_call: &RuntimeCall) -> bool {
// TODO review
// This needs to be addressed at EVM level
true
fn contains(call: &RuntimeCall) -> bool {
match call {
RuntimeCall::Balances(_) => true,
RuntimeCall::Ethereum(_) => true,
RuntimeCall::EVM(_) => true,
RuntimeCall::Utility(_) => true,
_ => false,
}
}
}

Expand Down
12 changes: 8 additions & 4 deletions runtime/moonriver/src/xcm_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,14 @@ parameter_types! {

pub struct SafeCallFilter;
impl frame_support::traits::Contains<RuntimeCall> for SafeCallFilter {
fn contains(_call: &RuntimeCall) -> bool {
// TODO review
// This needs to be addressed at EVM level
true
fn contains(call: &RuntimeCall) -> bool {
match call {
RuntimeCall::Balances(_) => true,
RuntimeCall::Ethereum(_) => true,
RuntimeCall::EVM(_) => true,
RuntimeCall::Utility(_) => true,
_ => false,
}
}
}

Expand Down