Fix lsp #24
Merged
Fix lsp #24
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetjinser
reviewed
Oct 15, 2025
Comment on lines
+37
to
+41
| env = [ | ||
| { | ||
| name = "MOON_HOME"; | ||
| value = "${pkgs.moonbit-bin.moonbit.latest}"; | ||
| } |
There was a problem hiding this comment.
Why is this needed? Isn't the MOON_HOME env provided when wrapping in lib/bundle.nix?
There was a problem hiding this comment.
Vscdoe extension needs this
Only setting the environment variable in the devshell envs make the extension use lsp in our package instead of the one bundled in extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr set the
MOON_HOMEfor lsp and flake dev template to make vscode extension detect the lsp and core lib correctly.