Skip to content

Conversation

@steven2308
Copy link
Contributor

This will be needed to register symbiotic operators the first time meta middleware is deployed.
It can be removed afterwards.

This will be needed to register symbiotic operators the first time meta middleware is deployed.
It can be removed afterwards.
@steven2308 steven2308 requested a review from NindoK December 10, 2025 19:51
@steven2308 steven2308 added D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes no-migration labels Dec 10, 2025
address[] calldata operators,
bytes32[] memory keys,
address middleware
) external onlyRole(DEFAULT_ADMIN_ROLE) onlyKnownMiddleware(middleware) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was going to get called directly by the middleware? Why by the admin? It would make sense to do everything on chain from the middleware and make those onlyRole admin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing this we don't even have to pass the address of th emiddleware, but we just check that the sender is a known middleware

Copy link
Collaborator

@NindoK NindoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather do from each middleware rather than admin

@steven2308
Copy link
Contributor Author

I'd rather do from each middleware rather than admin

I think you are missing the context of this task. This is to migrate.
When we deploy the middleware, Symbiotic will already have tens of operators. We will call this method once to migrate them so they are also tracked in the meta middleware, then we remove the method.

The rest of operations: register, unregister, update key, will call this directly. The methods for that already exist and must be called by the middlewares directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D2-notlive PR doesn't change runtime/client code no-migration not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants