Repository navigation
Made PlaybackStateObserverManager idempotent: - #21
Merged
Merged
Conversation
- startObserving() now no-ops if already observing. - stopObserving() now no-ops if not observing. After removal, it resets the observer instance so the manager can be safely restarted.
Contributor
Author
|
@moonggae could you please review this and release new ver when you have time? If possible, I'd really appreciate it if you could check it soon, as my iOS app is currently not working. |
Owner
|
Thanks for the fix. I added a regression test commit to this PR to cover the iOS observer lifecycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to verify the behavior please have a look at this branch:
https://github.com/msusman1/KMedia/tree/develop-nav
i have added some destinations