feat: Add support for custom HTTP headers in downloader#175
Open
spaceribs wants to merge 1 commit intomoonrepo:masterfrom
Open
feat: Add support for custom HTTP headers in downloader#175spaceribs wants to merge 1 commit intomoonrepo:masterfrom
spaceribs wants to merge 1 commit intomoonrepo:masterfrom
Conversation
milesj
reviewed
Mar 13, 2026
spaceribs
force-pushed
the
feat/download-options-headers
branch
from
3b8063b to
2e0a0b2
Compare
Author
|
@milesj I fixed up the formatting but it looks like theres a few unrelated issues on master at the moment, would you like me to resolve them as well? |
spaceribs
force-pushed
the
feat/download-options-headers
branch
from
2e0a0b2 to
8de7b27
Compare
- Introduced `new_with_headers` and `new_with_client_and_headers` methods in `DefaultDownloader` to allow setting custom headers for requests Ref: moonrepo/proto#964
spaceribs
force-pushed
the
feat/download-options-headers
branch
from
8de7b27 to
3b7d508
Compare
Collaborator
|
@spaceribs Formatting hates you right now hah. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new_with_headersandnew_with_client_and_headersmethods inDefaultDownloaderto allow setting custom headers for requestsRef: moonrepo/proto#964