Skip to content

Conversation

@anajuliabit
Copy link
Collaborator

@anajuliabit anajuliabit commented Oct 3, 2024

  • Move mint/borrow/supply tests from LiveSystem.t.sol to SupplyBorrow.t.sol
  • Add supply and borrow cap tests to SupplyBorrow.t.sol
  • Delete market-specific integration tests
  • Move Temporal governor tests from LiveSystem.t.sol to TemporalGovernor.t.sol
  • Loop over all active markets instead of getting mToken from fuzz (will be done in another PR)
  • Add more markets tests to SupplyBorrow.t.sol Market CF Integration Tests #218 (will be done in another PR)
  • Add more MRD tests to MultiRewardsDistributor.t.sol (will be done in another PR)
  • Add more temporal governor tests to TemporalGovernor.t.sol (will be done in another PR)

@anajuliabit anajuliabit changed the base branch from main to ci/sanity-checks-it October 3, 2024 16:18
Base automatically changed from ci/sanity-checks-it to main October 3, 2024 16:44
@openzeppelin-code
Copy link

openzeppelin-code bot commented Oct 3, 2024

Live System Integration Tests: split into multiple files, delete duplications and add more tests

Generated at commit: cc3260f9f344a3f51b477392fa04a2f26857352d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
4
3
0
14
45
66
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@anajuliabit anajuliabit changed the title Integration tests Improvements Markets Integration Tests: Split into multiple files and delete duplications Oct 3, 2024

if (supplyCap == 0) {
return type(uint256).max;
return type(uint128).max;
Copy link
Collaborator Author

@anajuliabit anajuliabit Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decreased otherwise mint fails with TOKEN_TRANSFER_IN_OVERFLOW

@anajuliabit anajuliabit changed the title Markets Integration Tests: Split into multiple files and delete duplications Live System Integration Tests: Split into multiple files and delete duplications Oct 4, 2024
@anajuliabit anajuliabit changed the title Live System Integration Tests: Split into multiple files and delete duplications Live System Integration Tests: Split into multiple files, delete duplications and add more tests Oct 4, 2024
@anajuliabit anajuliabit changed the title Live System Integration Tests: Split into multiple files, delete duplications and add more tests Live System Integration Tests: split into multiple files, delete duplications and add more tests Oct 4, 2024
@anajuliabit anajuliabit marked this pull request as ready for review October 4, 2024 17:28
@anajuliabit anajuliabit self-assigned this Oct 4, 2024
@github-actions
Copy link

github-actions bot commented Oct 4, 2024

No files changed, compilation skipped
Script ran successfully.
Gas used: 28225535

If you wish to simulate on-chain transactions pass a RPC URL.

Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes so far are looking good!

Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anajuliabit anajuliabit merged commit 525a8d3 into main Oct 6, 2024
19 checks passed
@anajuliabit anajuliabit deleted the it/live-system branch October 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants