-
Notifications
You must be signed in to change notification settings - Fork 33
Live System Integration Tests: split into multiple files, delete duplications and add more tests #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Live System Integration Tests: split into multiple files, delete duplications and add more tests
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
|
|
||
| if (supplyCap == 0) { | ||
| return type(uint256).max; | ||
| return type(uint128).max; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decreased otherwise mint fails with TOKEN_TRANSFER_IN_OVERFLOW
|
ElliotFriedman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes so far are looking good!
ElliotFriedman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Uh oh!
There was an error while loading. Please reload this page.