Fix/create morpho market #535

anajuliabit · 2025-10-16T20:28:49Z

Oracle contract management and configuration:

Added new Chainlink oracle implementation and proxy contract addresses, as well as a proxy admin, to the chains/8453.json configuration file. The deprecated oracle entry was renamed for clarity. [1] [2]
Refactored the OracleConfig struct in CreateMorphoMarket.s.sol to include a proxyAddressName field, enabling separation between logic and proxy contracts for oracles. [1] [2]
Updated the oracle deployment logic in CreateMorphoMarket.s.sol to deploy and register proxy contracts and proxy admin only if they do not already exist, improving upgradability and avoiding redundant deployments.

Market configuration updates:

Updated market JSON templates (meUSDC_MAMO_MARKET.json, meUSDC_WELL_MARKET.json, meUSDC_stkWELL_MARKET.json) to use the new oracle structure, referencing the correct logic and proxy names and adjusting market parameters for consistency. [1] [2] [3]

Script improvements:

Added a call to addresses.printAddresses() in the deployment script for easier debugging and verification of deployed contract addresses.

Copilot

Pull Request Overview

Adjusts market configuration templates and enhances oracle deployment logic to support reusable Chainlink proxy implementations for Morpho markets.

Adds proxyAddressName to oracle config and conditional deployment/reuse logic for Chainlink oracle proxy, proxy admin, and implementation.
Updates several market template JSON files with new oracle naming scheme and revised risk parameters (lltv, collateralAmount, borrowAssets).
Extends chain addresses registry with implementation/proxy/admin entries and marks an old oracle as deprecated.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
script/templates/markets/meUSDC_stkWELL_MARKET.json	Adds proxyAddressName and adjusts LLTV and asset amounts for stkWELL market.
script/templates/markets/meUSDC_WELL_MARKET.json	Switches to new oracle naming pattern and updates initial asset configuration.
script/templates/markets/meUSDC_MAMO_MARKET.json	Adds proxyAddressName and revises LLTV and collateral settings.
script/templates/CreateMorphoMarket.s.sol	Introduces proxyAddressName parsing and conditional deployment/reuse logic for Chainlink oracle proxies.
chains/8453.json	Renames deprecated oracle entry and adds new implementation/proxy/admin address records for multiple Chainlink oracles.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-16T20:31:52Z

script/templates/CreateMorphoMarket.s.sol

+                addresses.getAddress(ocfg.baseFeedName),
+                addresses.getAddress("TEMPORAL_GOVERNOR")
+            );
+            addresses.addAddress(proxyAddressName, address(proxy));


If the implementation address changes after initial deployment (e.g., logic upgraded), the existing proxy path (when proxyAddressName is already set) skips any upgrade and continues pointing to the old implementation, silently ignoring the new logicAddressName. Consider adding a branch to upgrade the proxy (via ProxyAdmin) when logicAddressName differs from current implementation.

Suggested change

addresses.addAddress(proxyAddressName, address(proxy));

addresses.addAddress(proxyAddressName, address(proxy));

} else {

proxy = TransparentUpgradeableProxy(

addresses.getAddress(proxyAddressName)

);

// Check if the proxy's implementation matches the latest logic address

address currentImpl = ProxyAdmin(address(proxyAdmin)).getProxyImplementation(proxy);

address newImpl = address(logic);

if (currentImpl != newImpl) {

ProxyAdmin(address(proxyAdmin)).upgrade(proxy, newImpl);

// Optionally, re-initialize if needed (only if the new implementation requires it)

// ChainlinkOracleProxy(address(proxy)).initialize(

// addresses.getAddress(ocfg.baseFeedName),

// addresses.getAddress("TEMPORAL_GOVERNOR")

// );

}

Copilot · 2025-10-16T20:31:53Z

script/templates/CreateMorphoMarket.s.sol

+            ChainlinkOracleProxy(address(proxy)).initialize(
+                addresses.getAddress(ocfg.baseFeedName),
+                addresses.getAddress("TEMPORAL_GOVERNOR")
+            );


Initialization now depends on an address lookup for TEMPORAL_GOVERNOR; if this key is unset the script will revert. Add a pre-check (e.g., require(addresses.isAddressSet("TEMPORAL_GOVERNOR"))) or fallback to msg.sender to avoid unexpected failure.

Copilot · 2025-10-16T20:31:53Z

script/templates/CreateMorphoMarket.s.sol

+        string memory logicAddressName = string(
+            abi.encodePacked(ocfg.proxyAddressName, "_IMPL")
+        );


If ocfg.proxyAddressName is missing or an empty string in the JSON config, names '_IMPL' and '_PROXY' will be produced, causing collisions or unintended lookups. Add validation that ocfg.proxyAddressName.length > 0 before constructing derived names.

Copilot · 2025-10-16T20:31:53Z

script/templates/CreateMorphoMarket.s.sol

+                addresses.getAddress("CHAINLINK_ORACLE_PROXY_ADMIN")
+            );
+        }



If ocfg.proxyAddressName is missing or an empty string in the JSON config, names '_IMPL' and '_PROXY' will be produced, causing collisions or unintended lookups. Add validation that ocfg.proxyAddressName.length > 0 before constructing derived names.

Suggested change

require(bytes(ocfg.proxyAddressName).length > 0, "proxyAddressName must be non-empty");

Copilot · 2025-10-16T20:31:54Z

chains/8453.json

        "addr": "0x245951c8a17Dd700a35a3CB6E2007C3E8D133F0b",
        "isContract": true,
-        "name": "MORPHO_CHAINLINK_WELL_USD_ORACLE"
+        "name": "MORPHO_CHAINLINK_WELL_USD_ORACLE_DEPRECATED"


[nitpick] Reusing the original name for a new address while keeping the deprecated one with a suffixed label can cause ambiguity in historical scripts expecting the old address. Consider a versioned naming (e.g., MORPHO_CHAINLINK_WELL_USD_ORACLE_V2) to distinguish active versus legacy instances unambiguously.

Suggested change

"name": "MORPHO_CHAINLINK_WELL_USD_ORACLE_DEPRECATED"

"name": "MORPHO_CHAINLINK_WELL_USD_ORACLE_V1"

Copilot · 2025-10-16T20:31:54Z

chains/8453.json

+    {
+        "addr": "0x71FBaD6c2200C8A5B89380f9B6bb8a35d411c852",
+        "isContract": true,
+        "name": "MORPHO_CHAINLINK_WELL_USD_ORACLE"


[nitpick] Reusing the original name for a new address while keeping the deprecated one with a suffixed label can cause ambiguity in historical scripts expecting the old address. Consider a versioned naming (e.g., MORPHO_CHAINLINK_WELL_USD_ORACLE_V2) to distinguish active versus legacy instances unambiguously.

Suggested change

"name": "MORPHO_CHAINLINK_WELL_USD_ORACLE"

"name": "MORPHO_CHAINLINK_WELL_USD_ORACLE_V2"

imthatcarlos

LGTM

anajuliabit added 5 commits October 16, 2025 15:13

Add addAddress calls after deploying oracle contracts

dd87a86

deprecated old chainilnk well usd oracle (used by llUSDC)

fad7e73

add well usdc proxy oracle addresses

424b9bc

only deploy's if not deployed

4ac9a4f

push last deployment

94490cd

anajuliabit marked this pull request as ready for review October 16, 2025 20:28

anajuliabit requested review from Copilot and imthatcarlos October 16, 2025 20:30

Copilot AI reviewed Oct 16, 2025

View reviewed changes

imthatcarlos approved these changes Oct 16, 2025

View reviewed changes

anajuliabit merged commit 1f09a0a into main Oct 16, 2025
24 checks passed

anajuliabit deleted the fix/create-morpho-market branch October 16, 2025 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/create morpho market #535

Fix/create morpho market #535

Uh oh!

anajuliabit commented Oct 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

imthatcarlos left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-            addresses.addAddress(proxyAddressName, address(proxy));
+            addresses.addAddress(proxyAddressName, address(proxy));
+        } else {
+            proxy = TransparentUpgradeableProxy(
+                addresses.getAddress(proxyAddressName)
+            );
+            // Check if the proxy's implementation matches the latest logic address
+            address currentImpl = ProxyAdmin(address(proxyAdmin)).getProxyImplementation(proxy);
+            address newImpl = address(logic);
+            if (currentImpl != newImpl) {
+                ProxyAdmin(address(proxyAdmin)).upgrade(proxy, newImpl);
+                // Optionally, re-initialize if needed (only if the new implementation requires it)
+                // ChainlinkOracleProxy(address(proxy)).initialize(
+                //     addresses.getAddress(ocfg.baseFeedName),
+                //     addresses.getAddress("TEMPORAL_GOVERNOR")
+                // );
+            }



	require(bytes(ocfg.proxyAddressName).length > 0, "proxyAddressName must be non-empty");

	"name": "MORPHO_CHAINLINK_WELL_USD_ORACLE_DEPRECATED"
	"name": "MORPHO_CHAINLINK_WELL_USD_ORACLE_V1"

Fix/create morpho market #535

Fix/create morpho market #535

Uh oh!

Conversation

anajuliabit commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

imthatcarlos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anajuliabit commented Oct 16, 2025 •

edited

Loading