fix: support TagSpec TLV fields in JSON export/import

[alovak]

Summary

• Add SkipUnknownTLVTags, StoreUnknownTLVTags, and PrefUnknownTLV to the builder's tagDummy struct so these TagSpec fields are preserved during JSON serialization
• Update importField and exportTag to read/write these fields, including prefix lookup validation for PrefUnknownTLV

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the JSON serialization and deserialization capabilities for TagSpec configurations by introducing support for specific TLV-related fields. The changes ensure that properties related to unknown TLV tag handling and prefixing are correctly persisted when converting MessageSpec objects to and from JSON, thereby maintaining data integrity across serialization boundaries.

Highlights

• Enhanced TagSpec Serialization: Added three new fields, SkipUnknownTLVTags, StoreUnknownTLVTags, and PrefUnknownTLV, to the tagDummy struct to ensure these TagSpec properties are correctly preserved during JSON export and import operations.
• Import/Export Logic Updates: Modified the importField and exportTag functions to properly handle the new TagSpec fields, including validation for the PrefUnknownTLV prefix during import.
• Comprehensive Testing: Introduced a new test case, TestExportImportTagSpecTLVFields, to verify the correct round-trip serialization and deserialization of these new TLV-related TagSpec fields.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds support for SkipUnknownTLVTags, StoreUnknownTLVTags, and PrefUnknownTLV fields to the TagSpec for JSON export and import. The changes are well-implemented, following the existing structure of the builder. The addition of TestExportImportTagSpecTLVFields is great as it ensures the new functionality is covered and that the JSON serialization is stable. I have one minor suggestion to improve code clarity.