fix: retain CDATA during signing

[ahrtmn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ahrtmn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where CDATA sections within XML documents were not consistently preserved during various XML signing and canonicalization operations. By setting doc.ReadSettings.PreserveCData = true in all relevant XML parsing contexts, the change ensures that the integrity of CDATA content is maintained throughout the signing workflow, preventing data loss or corruption. A new test case has been added to validate this behavior.

Highlights

• CDATA Preservation: Explicitly enabled CDATA section preservation during XML parsing in various canonicalization and signature processing functions to ensure that CDATA content is not lost or altered.
• New Test Case: Added a new test case to signedxml_test.go that specifically verifies the correct preservation of CDATA sections within XML documents after the signing process.
• Test Data: Introduced a new test data file, testdata/nosignature-cdata.xml, containing an XML structure with a nested CDATA section to support the new test case.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where CDATA sections were not being retained during XML signing by setting PreserveCData = true when parsing XML documents. The change is correct and includes a new test case to verify the fix. However, I've found a couple of places where the error returned from XML parsing is not handled, which could lead to panics. I've also noticed significant code duplication from adding this setting in multiple files and suggest a refactoring to improve maintainability.