Skip to content

Conversation

@Roaders
Copy link
Member

@Roaders Roaders commented Jan 27, 2026

fixes #272

@Roaders Roaders requested a review from a team as a code owner January 27, 2026 16:39
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 88.54962% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.00%. Comparing base (5280889) to head (6c5ecbc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
projects/fdc3-web/src/agent/desktop-agent.ts 82.95% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   91.03%   91.00%   -0.03%     
==========================================
  Files          40       40              
  Lines        5017     5056      +39     
  Branches      866      869       +3     
==========================================
+ Hits         4567     4601      +34     
- Misses        437      442       +5     
  Partials       13       13              
Flag Coverage Δ
unittests 91.00% <88.54%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ojects/fdc3-web/src/agent/desktop-agent.factory.ts 93.82% <100.00%> (ø)
...jects/fdc3-web/src/agent/fallback-open-strategy.ts 100.00% <100.00%> (ø)
...fdc3-web/src/app-directory/app-resolver.default.ts 95.00% <100.00%> (-1.50%) ⬇️
projects/fdc3-web/src/app-directory/directory.ts 90.99% <100.00%> (ø)
...ects/fdc3-web/src/helpers/type-predicate.helper.ts 93.75% <100.00%> (+1.85%) ⬆️
projects/ui-provider/src/app-resolver.component.ts 86.63% <100.00%> (+2.71%) ⬆️
projects/fdc3-web/src/agent/desktop-agent.ts 91.38% <82.95%> (-1.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Davidhanson90 Davidhanson90 self-requested a review January 28, 2026 13:59
@Roaders Roaders merged commit 42e8436 into morganstanley:main Jan 28, 2026
4 of 5 checks passed
@Roaders Roaders deleted the selectApplication branch January 28, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the ability to inform a consuming app when an intent is raised to an existing application

2 participants