Implement missing FDC3 Web Connection Protocol steps - #354
Open
Roaders wants to merge 1 commit into
Open
Conversation
Brings the getAgent()/Desktop Agent handshake in line with the FDC3 Web Connection Protocol (WCP1-WCP6): - Handle WCP2LoadUrl: load the agent URL into a hidden iframe and restart the handshake against it (isWCPLoadUrl predicate, ProxyUrl agent type). - Handle WCP5 failure end-to-end: reject getAgent() with AccessDenied on a WCP5ValidateAppIdentityFailedResponse (was an indefinite hang) and have the root send that response instead of going silent (isWCPFailedResponse). - Persist DesktopAgentDetails to SessionStorage and reconnect: read prior details, limit discovery to the previous mechanism, pass instanceId/ instanceUuid in WCP4 and reissue the same instanceId on the root. - Channel selector / intent resolver plumbing: WCP1Hello carries the channelSelector/intentResolver flags and the proxy injects UI iframes when the handshake supplies URLs. - Validate app identity origins: identityUrl, actualUrl and the WCP1Hello origin must match before identity is issued. - Failover: restart the handshake against a returned WindowProxy and reject unsupported results with InvalidFailover. - Clean up channel mappings on WCP6Goodbye. Adds unit and integration coverage for the new behaviours. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| }; | ||
| iframe.onerror = () => reject(AgentError.ErrorOnConnect); | ||
| iframe.src = url; |
| } | ||
| }; | ||
| iframe.onerror = () => reject(AgentError.ErrorOnConnect); | ||
| iframe.src = url; |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 91.59% 91.05% -0.55%
==========================================
Files 42 43 +1
Lines 5234 5521 +287
Branches 915 962 +47
==========================================
+ Hits 4794 5027 +233
- Misses 426 481 +55
+ Partials 14 13 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the getAgent()/Desktop Agent handshake in line with the FDC3 Web Connection Protocol (WCP1-WCP6):
Adds unit and integration coverage for the new behaviours.