Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #63 #71

Closed
wants to merge 1 commit into from
Closed

fix issue #63 #71

wants to merge 1 commit into from

Conversation

JRodez
Copy link

@JRodez JRodez commented May 26, 2023

'NoneType' object has no attribute 'get' #63 fixed with DDDOH answer

'NoneType' object has no attribute 'get' #63 fixed with DDDOH answer
@sergei-mironov
Copy link

sergei-mironov commented Jun 11, 2023

FYI: this PR did not fix the issue for me.
Some observations:

  • the following similar line still contains old-style names. I faced error on here as well.
  • Even after I fixed it, I see the following error
    ⠏ Querying projectTraceback (most recent call last):                                                                                                                                    [0/404]
    File "/workspace/modules/overleaf-sync/olsync/olsync.py", line 348, in execute_action
      success = action()
    File "/workspace/modules/overleaf-sync/olsync/olsync.py", line 175, in <lambda>
      lambda: overleaf_client.get_project(project_name),
    File "/workspace/modules/overleaf-sync/olsync/olclient.py", line 105, in get_project
      return next(OverleafClient.filter_projects(json_content, {"name": project_name}), None)
    File "/workspace/modules/overleaf-sync/olsync/olclient.py", line 42, in filter_projects
      if not p.get("archived") and not p.get("trashed"):
    AttributeError: 'str' object has no attribute 'get'
    

UPD: adding json_content = json_content["projects"] to the top of filter_projects function seems to fix this. I can even download pdfs, but syncing still does not work due to a problem described in #62 (does not appear to be working).
UPD2: #66 did work

@JRodez JRodez closed this by deleting the head repository Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants