Implement reserved.once #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morlovich
changed the title
morlovich
changed the title
morlovich
force-pushed
the
reserved-once
branch
from
e1a1dac to
0fa4bfd
Compare
…CG#1312) * Much of the function-level impl, though not fully wired still. * Some of the reporting args, commit function. * Rest of collecting stuff into context; pushing it into global contrib cache is remaining. * Almost there, still needs to invoke the function and deal with some refs. * Fix most imports. Now just need to run the actual report algorithm. * Maybe fix a build error. * IDL fix. * Fix a couple of TODOs, only the big one left. * Separate context for top-level and actually hook up commit. * A couple of bugfixes on proofreading. * When there is a winner, wait till navigation to send requests. * Fix arg list structure per feedback * Add a missing </div> * Update field comment + some function names. --------- Co-authored-by: Maks Orlovich <[email protected]>
morlovich
force-pushed
the
reserved-once
branch
from
0fa4bfd to
317754b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also re-links contributions with the function, which will matter for using the right the metrics.