Skip to content

Add ability to configure base config file path from an environment variable#2960

Open
sbordeyne wants to merge 54 commits into
morpheus65535:developmentfrom
sbordeyne:patch-1
Open

Add ability to configure base config file path from an environment variable#2960
sbordeyne wants to merge 54 commits into
morpheus65535:developmentfrom
sbordeyne:patch-1

Conversation

@sbordeyne
Copy link
Copy Markdown

This is a simple option that allows anyone to set the config.yaml file in another directory (or mount). This is especially handy if one wants to mount the configuration file as a configmap or kubernetes secret, in order to avoid permission issues.

It's a quick workaround, instead of having every variable be configurable through dedicated environment variables

github-actions Bot and others added 30 commits April 19, 2021 13:27
…5#1729)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.7.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.5.3...1.5.7)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1736)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.1.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.1.23...3.3.1)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts:
#	frontend/package-lock.json
Bumps [d3-color](https://github.com/d3/d3-color) to 3.1.0 and updates ancestor dependency [recharts](https://github.com/recharts/recharts). These dependencies need to be updated together.


Updates `d3-color` from 2.0.0 to 3.1.0
- [Release notes](https://github.com/d3/d3-color/releases)
- [Commits](d3/d3-color@v2.0.0...v3.1.0)

Updates `recharts` from 2.1.16 to 2.4.3
- [Release notes](https://github.com/recharts/recharts/releases)
- [Changelog](https://github.com/recharts/recharts/blob/master/CHANGELOG.md)
- [Commits](recharts/recharts@v2.1.16...v2.4.3)

---
updated-dependencies:
- dependency-name: d3-color
  dependency-type: indirect
- dependency-name: recharts
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts:
#	frontend/package-lock.json
…eus65535#2150)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.3.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.2.2...4.2.3)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
morpheus65535 and others added 24 commits June 24, 2023 18:17
# Conflicts:
#	frontend/package-lock.json
#	frontend/package.json
…5#2204)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5535#2198)

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.2 to 4.3.9.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.3.9/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts:
#	.github/workflows/ci.yml
Bumps [axios](https://github.com/axios/axios) from 1.6.8 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.8...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…riable

This is a simple option that allows anyone to set the config.yaml file in another directory (or mount). This is especially handy if one wants to mount the configuration file as a configmap or kubernetes secret, in order to avoid permission issues.

It's a quick workaround, instead of having every variable be configurable through dedicated environment variables
@morpheus65535
Copy link
Copy Markdown
Owner

Why not simply use the --config argument for Bazarr to store the whole config directory elsewhere? I don't see the point of adding another way to be more specific.

@sbordeyne
Copy link
Copy Markdown
Author

Thanks for your reply.

It's necessary because some deployment modes may want to mount the config as read-only.

When deploying on kubernetes with gitops best practices, it's much better to have the configuration as a kubernetes ConfigMap rather than relying on having to configure everything through the UI. In my case I'm not even exposing bazarr's UI to the network, everything comes in configured through the configuration files.

Due to the way bazarr works I still need persistent storage, but mounting config files in a PVC is not supported behaviour in kubernetes, since the whole mount point becomes read only (with just the config file being there).

Adding this option would provide the ability to define the configuration externally, mount it somewhere that is not in bazarr's main directory and have it read there.

@morpheus65535
Copy link
Copy Markdown
Owner

Rebase this on development branch and I'll merge it.

@sbordeyne sbordeyne changed the base branch from master to development July 19, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants