feat(providers): Add new subtitle provider - kickasssubtitles.#3216
Open
Shadoweee77 wants to merge 1 commit into
Open
feat(providers): Add new subtitle provider - kickasssubtitles.#3216Shadoweee77 wants to merge 1 commit into
Shadoweee77 wants to merge 1 commit into
Conversation
Author
|
Hey, hope You can merge it for the next release :) |
Owner
morpheus65535
left a comment
morpheus65535
left a comment
There was a problem hiding this comment.
Globally, I find this implementation complicated. I really don't understand why you've implemented async task. Why not a ProviderRetryMixin?
|
|
||
| def get_matches(self, video): | ||
| """Get matches for the subtitle.""" | ||
| matches = set() |
Owner
There was a problem hiding this comment.
Use self.matches here instead. We use this to log matches in history.
| logger.error("Unexpected error creating search task: %s", error) | ||
| return None | ||
|
|
||
| def _wait_for_task(self, task_id): |
Owner
There was a problem hiding this comment.
Why the whole async concept? What's the benefit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.