[Certora] Check Bundler safety #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin | Morpho 🦋 <[email protected]>
5 tasks
QGarchery
reviewed
Dec 13, 2024
|
converting to draft to make sure we don't merge by accident |
MathisGD
reviewed
Dec 16, 2024
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Colin | Morpho 🦋 <[email protected]>
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Colin | Morpho 🦋 <[email protected]>
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Colin | Morpho 🦋 <[email protected]>
This reverts commit 5f14bcc.
QGarchery
approved these changes
Dec 30, 2024
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Colin | Morpho 🦋 <[email protected]>
3 tasks
QGarchery
previously approved these changes
Dec 30, 2024
QGarchery
approved these changes
Jan 6, 2025
MathisGD
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to check the bundler's main safety properties.
Due to the complicated control flow involved in executing bundles, it may be hard to convince oneself that the Bundler behaves safely.
So we check that the transient storage is always in expected states, we ensure that reentering is only possible in expected situations and that bad configurations will revert.
Apparently, Certora's tools do not provide support for the
transientkeyword just yet, for this reason verification is run on munged files that implement transient variables using assembly instructions for the time being.Before accepting this PR make sure of the following: