Skip to content

use latest block #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adhusson wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

use latest block #235

adhusson wants to merge 4 commits into from

Conversation

@adhusson
Copy link
Contributor

@adhusson adhusson commented Jan 29, 2025 •
edited
Loading

must fix failing tests on ethereum first

@adhusson adhusson mentioned this pull request Jan 29, 2025
Merged
MathisGD
MathisGD previously approved these changes Jan 30, 2025
View reviewed changes
Base automatically changed from fix/restrict-receiver-on-deposit to main February 3, 2025 10:31
@adhusson adhusson dismissed MathisGD’s stale review February 3, 2025 10:31

The base branch was changed.

@MathisGD
Copy link
Contributor

MathisGD commented Feb 11, 2025

for MA3, we can simply keep the same block, as it is now being deprecated

@adhusson
Copy link
Contributor Author

adhusson commented Feb 11, 2025 •
edited
Loading

Tests pass, but I saw some transient failures on the following tests. I could not find which block number it was.

[FAIL: revert: TRANSFER_FROM_FAILED] testMigrateBorrowerDaiToSDaiWithPermit2() (gas: 7432427)
[FAIL: revert: TRANSFER_FROM_FAILED] testMigrateBorrowerWithPermit2() (gas: 5737762)
[FAIL: revert: TRANSFER_FROM_FAILED] testMigrateStEthPositionWithPermit2() (gas: 7151044)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MathisGD MathisGD MathisGD left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adhusson @MathisGD