feat: lockdown bundles before execution #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhusson
changed the title
adhusson
changed the title
adhusson
commented
Nov 10, 2024
src/Hub.sol
Outdated
| function multicallFromBundler(Call[] calldata bundle) external payable { | ||
| require(msg.sender == currentBundler(), ErrorsLib.UnauthorizedSender(msg.sender)); | ||
| _multicall(calls); | ||
| require(useBundleHash() == keccak256(callDataArgs()), ErrorsLib.InvalidBundle()); |
Contributor
Author
There was a problem hiding this comment.
This only checks that the stored bundle hash matches msg.data[4:].
It is technically possible to send extra calldata after the bundle argument such that bundle does not hash correctly and msg.data does hash correctly, but that would mean a hash collision was found.
Contributor
Author
|
Closing because the main usecase is a module that interacts with changing / upgradeable contracts. In this scenario the module can do the bundle integrity check itself. |
Closed
adhusson
changed the title
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock down bundle content and ordering. See issue #61.
multicallhas a 2nd argument:bytes32[] callbackBundlesHashes. The argument of the nth call tomulticallFromBundleris hashed and checked against the nthcallbackBundlesHashes.edit: compared to #165 / #167: