feat: slippage by price #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhusson
changed the base branch from
main
to
refactor/harmonize-amount-interpretation
Base automatically changed from
refactor/harmonize-amount-interpretation
to
main
November 19, 2024 10:32
MathisGD
reviewed
Nov 19, 2024
Contributor
Author
|
Made a fix + moved to |
MathisGD
reviewed
Nov 22, 2024
MathisGD
reviewed
Nov 22, 2024
MathisGD
reviewed
Nov 22, 2024
MathisGD
reviewed
Nov 22, 2024
MathisGD
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify slippage by price instead of limit amount, which became less useful since we stopped adjusting amounts that are not
type(uint).max.Notes:
E18to avoid any risk of error / confusion when e.g. called from the js. It makes the units obvious.wDivin the contract, multiply only. Possibility to completely remove the MathLib.sol import ifWADis redefined locally.