added remove button to clear request logs #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morsdyce
requested changes
Dec 16, 2019
| .filter((request) => includes(request.url, RequestLogState.query)) | ||
| .filter(filterLogByType) | ||
| .filter((request) => { | ||
| if(this.state.requestTimestamp != null) { |
Owner
There was a problem hiding this comment.
you can simplify this to if(!this.state.requestTimestamp)
| if(this.state.requestTimestamp != null) { | ||
| return request.startTime > this.state.requestTimestamp; | ||
| } else { | ||
| return request; |
Owner
There was a problem hiding this comment.
the return type for filter is either true/false so if you want to keep the request you need to return true
| <HeaderRow> | ||
| <HeaderCell width={ this.getCellWidth('time') } cell="time"> | ||
| <DeleteButton> | ||
| <Icon src="remove" onClick={this.clearLogs} /> |
Owner
There was a problem hiding this comment.
missing import for this component
…into clean-button-for-logs # Conflicts: # lib/ui/components/RequestLogs/RequestLog.js
Author
|
@morsdyce updated by the rejects, if there is anything else please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.