Unify PEFT logging codepaths #1655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
qq why we do this? |
Contributor
Author
|
We used to make an exception for PEFT models because mlflow couldn't completely support them, now MLFlow can so we can consolidate the codepaths. |
milocress
force-pushed
the
milo/unify-peft-codepath
branch
from
9634ce0 to
ee2fb11
Compare
Contributor
Author
|
IDK how this got closed lol |
Contributor
Author
|
Superseded by #1690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes special codepath for registering PEFT models and uses main hf checkpointing codepath.
Manual test
unify-codepaths-manual-test-Ha8qVx