fix: wildcard position detection#123
Merged
Merged
Conversation
This was referenced May 20, 2025
Contributor
Author
|
ps: I already successfully tested the added retained match patterns in abstract.js against this PR. |
robertsLando
changed the title
robertsLando
approved these changes
May 21, 2025
Member
|
Do you want me to merge this or we wait first to bump aedes-persistence? |
Contributor
Author
|
Let's merge this one now so the bug is fixed and we can then take our time to improve the test scenarios etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect position detection of wildcards during lookup of retained packets.
Kind regards,
Hans