fix: outgoingStream when no value is present for a key#126
Merged
robertsLando merged 2 commits intoOct 1, 2025
Conversation
Contributor
Author
|
BTW: I think that a similar issue could occur within createWillStream that also uses getDecodedValue() |
Contributor
Author
Second commit fixes that as well and adds a test for it to avoid future regressions. Kind regards, |
robertsLando
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes moscajs/aedes#1051 it also adds a test to avoid regressions.
Kind regards,
Hans