(MOSIP-44258) to set global parameter#1719
(MOSIP-44258) to set global parameter#1719Ivanmeneges wants to merge 5 commits intomosip:release-1.2.1.xfrom
Conversation
Signed-off-by: Ivanmeneges <[email protected]>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdates to deployment scripts: MinIO Helm install now sets Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Ivanmeneges <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployment/v3/mosip/config-server/copy_cm.sh`:
- Line 13: The call to the copy utility ($COPY_UTIL) is passing an incorrect 5th
positional argument ("copy_cm.sh"), causing the destination ConfigMap to be
named invalidly; update the invocation in
deployment/v3/mosip/config-server/copy_cm.sh to pass only four arguments
(preserving the original name) or replace the 5th argument with the intended
name "postgres" so the command becomes: use the same source name
"postgres-setup-config" and destination namespace $DST_NS while ensuring the
destination ConfigMap name is "postgres"; locate the call referencing $COPY_UTIL
and fix the extra/incorrect argument accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2debfaae-eab8-4ab6-b308-31674201d60f
📒 Files selected for processing (1)
deployment/v3/mosip/config-server/copy_cm.sh
Updated install script to use static values for gateway host and service host. Adjusted helm install commands to incorporate new variables. Signed-off-by: Ivanmeneges <[email protected]>
Signed-off-by: Ivanmeneges <[email protected]>
Signed-off-by: Ivanmeneges <[email protected]>
Summary by CodeRabbit