Skip to content

(MOSIP-44258) to set global parameter#1719

Open
Ivanmeneges wants to merge 5 commits intomosip:release-1.2.1.xfrom
Ivanmeneges:patch-5
Open

(MOSIP-44258) to set global parameter#1719
Ivanmeneges wants to merge 5 commits intomosip:release-1.2.1.xfrom
Ivanmeneges:patch-5

Conversation

@Ivanmeneges
Copy link
Copy Markdown
Contributor

@Ivanmeneges Ivanmeneges commented Apr 23, 2026

Summary by CodeRabbit

  • Chores
    • Updated MinIO deployment to allow insecure container images during installation.
    • Added an extra config copy step to include the Postgres setup configuration in the configuration server.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@Ivanmeneges has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 5 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4da10645-e229-4687-a87c-bda2cbe6ed61

📥 Commits

Reviewing files that changed from the base of the PR and between 6249cb8 and 1026474.

📒 Files selected for processing (2)
  • deployment/v3/mosip/config-server/copy_cm.sh
  • deployment/v3/mosip/prereg/install.sh

Walkthrough

Updates to deployment scripts: MinIO Helm install now sets global.security.allowInsecureImages=true; config-server copy script adds copying postgres-setup-config into postgres configmap. Minor EOF newline addition in the MinIO script.

Changes

Cohort / File(s) Summary
MinIO Helm Configuration
deployment/v3/external/object-store/minio/install.sh
Set global.security.allowInsecureImages=true in Helm chart values; added trailing newline.
Config-server ConfigMap Copies
deployment/v3/mosip/config-server/copy_cm.sh
Added an extra configmap copy step to transfer postgres-setup-config (source) → postgres (target) in config-server.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through scripts with a cheerful grin,
Poked a configmap and let new values in,
Allowed a daring image to play,
Copied postgres setup on its way,
A newline nods — all set to begin. 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and non-descriptive; it refers to setting a 'global parameter' without clarifying what parameter or its purpose, making it unclear to reviewers scanning the history. Revise the title to be more specific and descriptive of the actual changes, such as 'Allow insecure MinIO images and add postgres-setup-config configmap copy' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@deployment/v3/mosip/config-server/copy_cm.sh`:
- Line 13: The call to the copy utility ($COPY_UTIL) is passing an incorrect 5th
positional argument ("copy_cm.sh"), causing the destination ConfigMap to be
named invalidly; update the invocation in
deployment/v3/mosip/config-server/copy_cm.sh to pass only four arguments
(preserving the original name) or replace the 5th argument with the intended
name "postgres" so the command becomes: use the same source name
"postgres-setup-config" and destination namespace $DST_NS while ensuring the
destination ConfigMap name is "postgres"; locate the call referencing $COPY_UTIL
and fix the extra/incorrect argument accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2debfaae-eab8-4ab6-b308-31674201d60f

📥 Commits

Reviewing files that changed from the base of the PR and between bb18771 and 6249cb8.

📒 Files selected for processing (1)
  • deployment/v3/mosip/config-server/copy_cm.sh

Comment thread deployment/v3/mosip/config-server/copy_cm.sh Outdated
Updated install script to use static values for gateway host and service host. Adjusted helm install commands to incorporate new variables.

Signed-off-by: Ivanmeneges <[email protected]>
Signed-off-by: Ivanmeneges <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant