Skip to content

pin Helm version #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacewander merged 1 commit into from
Sep 1, 2025
Merged

pin Helm version #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion e2e/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ include ../common.mk
KUBECTL ?= $(LOCALBIN)/kubectl
KIND ?= $(LOCALBIN)/kind
HELM ?= $(LOCALBIN)/helm
# Pin to older version because newer Helm (v3.18.6) triggers unexpected schema validation errors
HELM_VERSION ?= v3.17.1

@spacewander spacewander Sep 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about why we need to pin the version?


.PHONY: kubectl
kubectl: $(LOCALBIN)
Expand All @@ -30,7 +32,7 @@ kind: $(LOCALBIN)
# we can't install it via `go install` because a limitation: https://github.com/golang/go/issues/44840
.PHONY: helm
helm: $(LOCALBIN)
@test -x $(HELM) || curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | USE_SUDO=false HELM_INSTALL_DIR=$(LOCALBIN) bash
@test -x $(HELM) || USE_SUDO=false HELM_INSTALL_DIR=$(LOCALBIN) bash -c "curl -fsSL https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash -s -- -v $(HELM_VERSION)"

.PHONY: create-cluster
create-cluster: kind kubectl
Expand Down
Loading