fix(native): swift staticlib --lib filter + python maturin module-name#31
Merged
Merged
Conversation
Two first-release failures in release-native.yml: - swift: cargo rustc --crate-type staticlib failed because --features uniffi also selects the uniffi-bindgen bin target (crate types can only target one target). Add --lib to filter to the library target. Verified locally. - python: maturin rejected the module name because the distribution name metamorphic-log contains '-'. Pin [tool.maturin] module-name to the uniffi namespace metamorphic_log.
The Maven job failed at Gradle configuration: plugin
com.gradleup.nmcp.aggregation:0.0.9 does not exist (scaffold placeholder
version). Latest is 1.6.1; the DSL we used (nmcpAggregation { centralPortal
{...} } + nmcpAggregation(project(...)) + com.gradleup.nmcp on subprojects +
publishAggregationToCentralPortal) matches 1.6.x per the nmcp docs.
Contributor
Author
|
Added a third fix: the Maven job failed at Gradle config with Run 29534041229 summary: guard PASS, all 4 desktop JVM libs PASS, bindings smokes PASS. Failures were swift (--lib), python (module-name), maven (nmcp version) - all three now in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First
native-v0.1.11release run surfaced two config bugs (guard, all desktop JVM libs, and bindings smokes passed; swift + all python legs failed).Swift xcframework -
cargo rustc --release --features uniffi --crate-type staticlibfailed with crate types to rustc can only be passed to one target, because--features uniffialso enables theuniffi-bindgenbin target. Fix: add--lib. Verified locally onaarch64-apple-darwin(produceslibmetamorphic_log.a, no error).Python wheels (all legs) - maturin failed with The module name must not contain a minus, because the distribution name
metamorphic-loghas a-. Fix: pin[tool.maturin] module-name = "metamorphic_log"(the uniffi namespace fromsrc/lib.rs).actionlint clean. Publish steps remain gated off.