Annotate NIF-boundary arity for Credo#7
Merged
Merged
Conversation
nif_signed_policy_sign mirrors the Rust #[rustler::nif] signature 1:1 (arity 12). The ergonomic public API is Policy.sign/2 (keyword list); grouping the fields into a struct would only move the fan-out into a NIF decoder. Waive Credo.Check.Refactor.FunctionArity inline for this private, @moduledoc false binding stub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silences the sole Credo refactoring finding (
Credo.Check.Refactor.FunctionArity, arity 12 > max 8) onMetamorphicLog.Native.nif_signed_policy_sign.The stub mirrors the Rust
#[rustler::nif]signature one-to-one, and the ergonomic public API (MetamorphicLog.Policy.sign/2, keyword list) already hides it. Grouping the fields into a struct would only move the fan-out into a NIF decoder without improving any caller, so the check is waived inline (in-source annotation — no added dependency) for this private,@moduledoc falsebinding stub.Lands ahead of the v0.1.6 tag. Part of board task #55 (Step D).