Skip to content

feat: hide performance menu item if disabled#832

Open
g2mt wants to merge 1 commit into
mostlygeek:mainfrom
g2mt:hide-performance
Open

feat: hide performance menu item if disabled#832
g2mt wants to merge 1 commit into
mostlygeek:mainfrom
g2mt:hide-performance

Conversation

@g2mt

@g2mt g2mt commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I use llama-swap to connect to a remote server for inference. I do not need to view the performance of the client running llama-swap. The addition of the Performance tab clutters the navigation bar. This patch hides the Performance item of the navigation bar if its disabled.

Deepseek was used to generate this commit.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2360eb01-9a44-4559-9c2a-3edb3124aac6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explaining the motivation (hiding Performance tab when disabled for remote inference scenarios) and noting Deepseek assistance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'feat: hide performance menu item if disabled' directly describes the main user-facing change—conditionally hiding the Performance navigation link based on server status.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@g2mt g2mt changed the title feat(server): add performance status endpoint and conditional UI link feat: hide performance menu item if disabled Jun 11, 2026
Assisted-by: pi:DeepSeek V4 Pro
@g2mt g2mt force-pushed the hide-performance branch from 18ee926 to 65a9199 Compare June 11, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant