-
Notifications
You must be signed in to change notification settings - Fork 0
Feature#79 모의수능 신청 API 연동 #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 추가 및 변경된 파일총 45개 파일 변경 |
✅ Mosu Admin 빌드가 성공적으로 완료되었습니다!📋 빌드 결과
🚀 다음 단계코드 리뷰 후 머지하면 프로덕션에 배포됩니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes introduce API integrations, form handling with react-hook-form, and architectural improvements using getServerSideProps and context splitting. The payment flow refactoring using the Chain of Responsibility pattern is a significant enhancement. The review identified critical and high-severity issues related to hardcoded values and potential null pointer exceptions.
| placeholder="이름을 입력해주세요." | ||
| required={true} | ||
| disabled={true} | ||
| value={profileData!.userName} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-null assertion operator (!) is used on profileData. However, profileData can be null if the initial data fetch in getServerSideProps fails. This will cause a runtime crash. Please add a guard clause at the beginning of the component to handle the case where profileData is null, such as rendering a loading state or redirecting to an error page.
✅ Mosu Admin 빌드가 성공적으로 완료되었습니다!📋 빌드 결과
🚀 다음 단계코드 리뷰 후 머지하면 프로덕션에 배포됩니다. |
📚 Storybook이 Chromatic에 배포되었습니다!
|
kimgho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많으셨습니다~
다음엔 커밋을 좀 나눠주시는게..😂
| @singleton() | ||
| export class ProcessEasyPaymentHandler extends PaymentHandler<PreparePaymentPayload> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
클래스가 인상깊네요..
의존성이 많아서 ㅠㅠ 커밋량이 좀많았어요 |
✅ Linked Issue
🔍 What I did
🔧 Additional context
2025-07-18.12.16.46.mov
의존성이 많아서 ㅠㅠ 커밋량이 좀많아요
다음작업부터는 잘게쪼개서 PR 올리겠습니다!
🚧 TODO (if any)