Feature#160 페이지 전환시 progressbar 추가 #161
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a global progress bar to enhance the user experience during page navigation within the Next.js application. By displaying a progress indicator, users are kept informed during loading states, particularly when data fetching mechanisms like getServerSideProps or getStaticProps with ISR fallback are active.
Highlights
- Progress Bar Integration: I've integrated the
nprogresslibrary to display a visual progress bar during page transitions in the application. This provides immediate feedback to users when navigating between pages. - Next.js Router Event Handling: The progress bar is configured in
_app.tsxto automatically start when a Next.js route change begins (routeChangeStart) and to complete when the route change finishes, whether successfully or with an error (routeChangeComplete,routeChangeError). The spinner is hidden for a cleaner look. - Dependency Management: The
nprogresspackage and its corresponding TypeScript types (@types/nprogress) have been added to the project's dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
📦 Package 변경사항
📝 추가 및 변경된 파일총 4개 파일 변경 |
| NProgress.configure({ showSpinner: false }); | ||
|
|
||
| Router.events.on("routeChangeStart", () => { | ||
| NProgress.start(); | ||
| }); | ||
| Router.events.on("routeChangeComplete", () => { | ||
| NProgress.done(); | ||
| }); | ||
| Router.events.on("routeChangeError", () => { | ||
| NProgress.done(); | ||
| }); |
There was a problem hiding this comment.
Consider encapsulating the NProgress configuration and event listener setup within a useEffect hook. This ensures proper lifecycle management, especially regarding cleanup to avoid potential memory leaks or unexpected behavior during hot module replacement. It also centralizes the logic related to the progress bar within the component.
Here's a suggested refactor:
useEffect(() => {
NProgress.configure({ showSpinner: false });
const handleStart = () => NProgress.start();
const handleStop = () => NProgress.done();
Router.events.on("routeChangeStart", handleStart);
Router.events.on("routeChangeComplete", handleStop);
Router.events.on("routeChangeError", handleStop);
return () => {
Router.events.off("routeChangeStart", handleStart);
Router.events.off("routeChangeComplete", handleStop);
Router.events.off("routeChangeError", handleStop);
};
}, []);
📚 Storybook이 Chromatic에 배포되었습니다!
|
📚 Storybook이 Chromatic에 배포되었습니다!
|
| NProgress.configure({ showSpinner: false }); | ||
|
|
✅ Linked Issue
🔍 What I did
_app.tsx에서 ProgressBar 설정2025-07-18.2.08.49.mov
💡 Why I did it