Fix384: 메드스카이 제휴 링크 변경 #384
Conversation
WalkthroughUpdates the first carousel item's href in mosu-app/src/widgets/home/ReviewSection.tsx to point to https://www.medsky.co.kr/consulting/jungsi/forMosu instead of the previous fbclid-tracked Medsky URL. No other logic, items, or exports are changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 추가 및 변경된 파일총 1개 파일 변경 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
mosu-app/src/widgets/home/ReviewSection.tsx (1)
195-203: Prevent reverse‑tabnabbing on external opens.
window.open(url, "_blank")leaveswindow.openerintact, enabling tabnabbing. Addnoopener,noreferrer(and nullify opener as a fallback).Apply:
- onClick={() => item.href && window.open(item.href, "_blank")} + onClick={() => { + if (!item.href) return; + const w = window.open(item.href, "_blank", "noopener,noreferrer"); + if (w) w.opener = null; + }}Alternative (preferred for a11y/semantics): wrap the Image with an
<a href target="_blank" rel="noopener noreferrer">.
🧹 Nitpick comments (2)
mosu-app/src/widgets/home/ReviewSection.tsx (2)
40-45: Expose per-item alt text for accessibility.
alt="제휴처"is too generic for screen readers/SEO. Allowaltper item and default if missing.export interface PartnershipCarouselProps { carouselItems: Array<{ href?: string; imgSrc: StaticImageData; + alt?: string; }>; }- alt="제휴처" + alt={item.alt ?? "제휴처"}Also applies to: 195-201
25-27: Consider removing fbclid from the second partner URL.To be consistent with this PR’s cleanup and avoid tracking noise, replace the fbclid-tracked URL with its canonical destination if possible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
mosu-app/src/widgets/home/ReviewSection.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Run Unit & Integration Tests
- GitHub Check: Run DangerJS
🔇 Additional comments (1)
mosu-app/src/widgets/home/ReviewSection.tsx (1)
21-23: Medsky link change LGTM; please confirm final destination.Good switch to the clean, canonical HTTPS URL and removal of tracking. Please quickly verify this path doesn’t 301/302 elsewhere and that any CSP/allowlist includes
medsky.co.kr.
📚 Storybook이 Chromatic에 배포되었습니다!
|
🔍 What I did
Summary by CodeRabbit