Feature#388 topRatedSchools 필터링 로직 추가하여 null 값 제거

[toothlessdev]

✅ Linked Issue

• [✨ 기능 요청] 학교대항전 이벤트 페이지 구현 #388

Summary by CodeRabbit

• Bug Fixes
  • Corrected the Top Schools list by excluding entries without a school name, preventing blank/unnamed items from appearing.
  • Rankings and Top 3 highlights are now computed only from valid schools, preserving the existing sort order and top‑20 limit.
  • No changes to page layout or refresh timing; users will see a cleaner, more accurate leaderboard, improving clarity and trust in the standings.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
mosu-client	Building	Preview	Comment	Sep 8, 2025 6:36pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The static props generation for the competition events page now filters out schools with null schoolName before sorting by paidApplicationCount, selecting the top 20, and deriving top3Schools from that list. Returned props and revalidation settings remain unchanged.

Changes

Cohort / File(s)	Summary of changes
Competition events page data prep mosu-app/src/pages/events/competition/index.tsx	Added a pre-sort filter to exclude entries with null schoolName. Retained existing sorting by paidApplicationCount, slicing to top 20, and deriving top3Schools from the first three. No exported/public API changes.

Sequence Diagram(s)

sequenceDiagram
    participant Build as Next.js Build (SSG)
    participant Data as Data Source
    participant Page as Competition Page

    Build->>Data: Fetch schools
    Data-->>Build: Schools[]
    note over Build: Filter: schoolName != null
    Build->>Build: Sort by paidApplicationCount (desc)
    Build->>Build: Slice top 20
    Build->>Build: Derive top3Schools from first 3
    Build-->>Page: props { topSchools, top3Schools, ... }
    Page->>Page: Render with provided props

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hop through lists with whiskered care,
Null names? I leave them in the air.
Sort, slice—twenty beans aligned,
Top three carrots neatly mined.
Thump-thump! The page now squeaks with pride—
Clean arrays for a smoother ride. 🥕🐇

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  - Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
  - Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 120d918 and 432d8e5.

📒 Files selected for processing (1)

• mosu-app/src/pages/events/competition/index.tsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature#388

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

	Warnings
⚠️	PR에 Reviewers가 지정되어 있지 않습니다. 리뷰어를 지정해주세요.

	Messages
📖	✅ PR 제목에 이슈 번호가 포함되어 있습니다.
📖	✅ PR에 라벨이 지정되어 있습니다.
📖	✅ PR에 Assignees가 지정되어 있습니다.
📖	✅ package.json에 변경사항이 없습니다.
📖	✅ 브랜치 이름 'feature#388'이 컨벤션을 따릅니다.
📖	✅ TypeScript 컴파일이 성공적으로 완료되었습니다.
📖	✅ ESLint 검사 결과 문제가 없습니다.

📝 추가 및 변경된 파일

총 1개 파일 변경

└── 📂 mosu-app/
    └── 📂 src/
        └── 📂 pages/
            └── 📂 events/
                └── 📂 competition/
                    └── ⚛️ index.tsx

Generated by 🚫 dangerJS against 432d8e5

[github-actions]

📚 Storybook이 Chromatic에 배포되었습니다!

• 🔗 Storybook Preview: https://www.chromatic.com/build?appId=68627ee20725077171386a15&number=231
• 🚀 Chromatic Build: https://www.chromatic.com/build?appId=68627ee20725077171386a15&number=231