Fix#388 학교대항전 순위로직 변경

[toothlessdev]

✅ Linked Issue

• [✨ 기능 요청] 학교대항전 이벤트 페이지 구현 #388

Summary by CodeRabbit

• New Features
  • Ranking table now shows progress gaps relative to anchor groups (top 1, top 5, top 20) for clearer standings and comparisons.
• Style
  • Updated heading copy for improved clarity.
  • Revised rank info card ranges (now 6–20위) and units (now 마리), and adjusted displayed value to better match context.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
mosu-client	Building	Preview	Comment	Sep 9, 2025 10:21am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Updates competition InfoSection copy and adjusts RankTableSection’s gap and prevRank computation to use anchor ranks (1, 5, 20) based on the current row’s rank group. Rank 1 remains special-cased. No exported APIs changed.

Changes

Cohort / File(s)	Summary
Competition info copy updates mosu-app/src/widgets/competition/InfoSection.tsx	Updated heading text; modified third RankInfoCard content (rank range 6~20, value 1, unit delimiter changed to "마리"). No structural or logic changes.
Rank table gap/prevRank logic mosu-app/src/widgets/competition/RankTableSection.tsx	Replaced index-based computations with group anchors: ranks 2–5 compare to rank 1; 6–20 compare to rank 5; 21+ compare to rank 20. Passed prevRank as the anchor rank. Rank 1 unchanged (gap=0, prevRank=0).

Sequence Diagram(s)

sequenceDiagram
  participant UI as CompetitionPage
  participant RTS as RankTableSection
  participant RTR as RankTableRow

  UI->>RTS: render(topRatedSchools)
  loop for each school (rank r)
    RTS->>RTS: determine anchor\nr==1 -> 0\n2..5 -> 1\n6..20 -> 5\n21+ -> 20
    RTS->>RTS: targetRank = {1,5,20} by group
    RTS->>RTS: targetCount = paidCount(targetRank)
    RTS->>RTS: gap = targetCount - paidCount(r)
    RTS->>RTR: renderRow({ rank:r, prevRank:targetRank, gap })
  end
  note over RTS,RTR: Rank 1: gap=0, prevRank=0 (unchanged)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix#388 상위 학교 정렬 로직 개선 및 RankTableRow 컴포넌트 수정 #392: Adjusts RankTableSection row prevRank/gap derivation and rendering logic in a similar manner.
• Fix#388 topRatedSchools 정렬 로직 추가 #390: Changes sorting of topRatedSchools by paidApplicationCount, which directly affects the new anchor-based gap computations.
• Fix#388 학교 경쟁 페이지 및 순위 테이블 스타일 변경 #391: Touches competition rank table props/logic and InfoSection text, overlapping with this PR’s areas.

Poem

A carrot of ranks, a ladder to see,
From one to five to twenty, we leap with glee.
Numbers align, the gaps now clear,
Tables march steady—no bugs to fear.
I thump my paws: “Ship it!”—hoppily. 🥕🐇

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19c38ce and 6daab27.

📒 Files selected for processing (2)

• mosu-app/src/widgets/competition/InfoSection.tsx (2 hunks)
• mosu-app/src/widgets/competition/RankTableSection.tsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature#388

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

	Warnings
⚠️	PR에 Reviewers가 지정되어 있지 않습니다. 리뷰어를 지정해주세요.

	Messages
📖	✅ PR 제목에 이슈 번호가 포함되어 있습니다.
📖	✅ PR에 라벨이 지정되어 있습니다.
📖	✅ PR에 Assignees가 지정되어 있습니다.
📖	✅ package.json에 변경사항이 없습니다.
📖	✅ 브랜치 이름 'feature#388'이 컨벤션을 따릅니다.
📖	✅ TypeScript 컴파일이 성공적으로 완료되었습니다.
📖	✅ ESLint 검사 결과 문제가 없습니다.

📝 추가 및 변경된 파일

총 2개 파일 변경

└── 📂 mosu-app/
    └── 📂 src/
        └── 📂 widgets/
            └── 📂 competition/
                ├── ⚛️ InfoSection.tsx
                └── ⚛️ RankTableSection.tsx

Generated by 🚫 dangerJS against 6daab27

[github-actions]

📚 Storybook이 Chromatic에 배포되었습니다!

• 🔗 Storybook Preview: https://www.chromatic.com/build?appId=68627ee20725077171386a15&number=232
• 🚀 Chromatic Build: https://www.chromatic.com/build?appId=68627ee20725077171386a15&number=232