-
Notifications
You must be signed in to change notification settings - Fork 0
Fix#397 페이지 리뉴얼을 위한 모달창 추가 #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughReplaced RankBadge SVG usage with Next.js Image and updated corresponding SCSS selectors and scaling. Enabled rank sections on the competition page with computed top3Schools/topRatedSchools props. Added an informational overlay in _app. Adjusted footer content by removing the D-day promo. Made RankListSection badges render conditionally. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant App as _app.tsx
participant Overlay as useOverlay Hook
participant UI as BannerProvider
User->>App: Load application
App->>Overlay: useOverlay({ title: "안내사항", initialOpen: true })
Overlay-->>App: renderOverlay(content)
App->>UI: Render layout
App->>UI: renderOverlay(overlayContent)
UI-->>User: Overlay displayed
sequenceDiagram
autonumber
participant SSG as getStaticProps
participant Page as Competition Page
participant RankList as RankListSection
participant RankTable as RankTableSection
Note over SSG: Compute topRatedSchools<br/>Derive top3Schools
SSG-->>Page: props { top3Schools, topRatedSchools }
Page->>RankList: top3Schools
alt For each index 0..2
RankList->>RankList: Conditionally render RankBadge if exists
end
Page->>RankTable: topRatedSchools
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 추가 및 변경된 파일총 6개 파일 변경 |
📚 Storybook이 Chromatic에 배포되었습니다!
|
✅ Linked Issue
Summary by CodeRabbit
New Features
Bug Fixes
Style
Content