[배포] 내 문의 내역 조회 시 답변도 같이 반환 #291
Conversation
MOSU-287 refactor: 내 질문 조회 시 답변도 같이 전달
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @wlgns12370, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented a change that enhances the user's ability to view their inquiry history. Previously, when a user fetched their inquiries, only the inquiry details were returned. With this update, the system will now also return the corresponding answer for each inquiry, providing a more complete and immediate view of their support interactions. This involved updating the data models, service layer, and repository query logic to correctly fetch and present this combined information.
Highlights
- New Data Transfer Objects (DTOs): I've introduced two new DTOs:
InquiryAnswerResponseto model the answer details andInquiryListResponseto combine an inquiry with its answer, providing a richer data structure for the client. - Service and Repository Layer Updates: The
getMyInquirymethod inInquiryServiceandsearchMyInquiryinInquiryQueryRepositoryhave been updated to returnPage<InquiryListResponse>, ensuring that inquiry answers are included in the list view. - Query Logic Enhancement: I've modified
InquiryJpaRepositoryImplto include aLEFT JOINwith theinquiryAnswerentity when fetching user inquiries, allowing answers to be retrieved alongside the main inquiry data. A new mapping methodmapToInquiryListResponsehandles the conversion to the new DTO. - API Endpoint Modification: The
InquiryControllerand its documentation interfaceInquiryControllerDocshave been adjusted to reflect the change in the return type for the/myendpoint, ensuring API consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully implements the feature of including answers when fetching a user's inquiry list. The changes are well-structured, introducing new DTOs for the combined response and updating the repository layer to perform a LEFT JOIN to fetch the related answer data. The refactoring to move mapping logic from the DTO to the repository implementation is a good improvement for separation of concerns. I've found one area for improvement regarding dynamic sorting in the new query. Please see the detailed comment.
| List<InquiryListResponse> content = query | ||
| .orderBy(inquiry.createdAt.desc()) | ||
| .offset(pageable.getOffset()) | ||
| .limit(pageable.getPageSize()) | ||
| .fetch().stream() | ||
| .map(this::mapToResponse) | ||
| .map(this::mapToInquiryListResponse) | ||
| .toList(); |
There was a problem hiding this comment.
The sorting is hardcoded to be descending by createdAt. The Pageable object, which is passed as an argument to this method, can contain sorting information from the client request, but it is being ignored. This prevents clients from sorting the inquiry list according to their needs. It is recommended to use the Sort information from the Pageable object to apply dynamic sorting. You could adapt the existing buildOrderByCondition method or create a new helper to handle this.
✨ 구현한 기능
이슈